Skip to content

Commit 7603ec2

Browse files
Rick Ratmanskymeta-codesync[bot]
authored andcommitted
Remove DI stat tracking from redex PrintKotlinStats
Summary: Remove the di_generated_class stat tracking from PrintKotlinStats across all redex variants (redex, redex-frozen, redex-stable, redex-staging). This stat tracked classes extending the DI base module class, but DI modules no longer use base class inheritance - they use InjectorModule annotations instead. The stat hasn't been used for years. Reviewed By: wsanville Differential Revision: D96128032 fbshipit-source-id: f0341d04cebbdad4cf21425c060611982f85c92b
1 parent 1e67702 commit 7603ec2

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

opt/print-kotlin-stats/PrintKotlinStats.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ constexpr const char* RW_PROP_SIGNATURE =
2323
"Lkotlin/properties/ReadWriteProperty;";
2424
constexpr const char* KPROPERTY_ARRAY = "[Lkotlin/reflect/KProperty;";
2525
constexpr const char* KOTLIN_LAMBDA = "Lkotlin/jvm/internal/Lambda;";
26-
constexpr const char* DI_BASE = "Lcom/facebook/inject/AbstractLibraryModule;";
2726
constexpr const char* CONTINUATION_IMPL =
2827
"Lkotlin/coroutines/jvm/internal/ContinuationImpl;";
2928
// A lambda like { true } has 4 instructions.
@@ -119,7 +118,6 @@ void PrintKotlinStats::setup() {
119118
kotlin_nullcheck_wrapper::get_kotlin_null_assertions();
120119
m_kotlin_lambdas_base = DexType::get_type(KOTLIN_LAMBDA);
121120
m_kotlin_coroutin_continuation_base = DexType::get_type(CONTINUATION_IMPL);
122-
m_di_base = DexType::get_type(DI_BASE);
123121
m_instance = DexString::make_string("INSTANCE");
124122
}
125123

@@ -192,10 +190,6 @@ PrintKotlinStats::Stats PrintKotlinStats::handle_class(
192190
stats.kotlin_coroutine_continuation_base++;
193191
}
194192

195-
if (cls->get_super_class() == m_di_base) {
196-
stats.di_generated_class++;
197-
}
198-
199193
for (auto* field : cls->get_sfields()) {
200194
if (field->get_name() == m_instance &&
201195
field->get_type() == cls->get_type()) {
@@ -366,7 +360,6 @@ void PrintKotlinStats::Stats::report(PassManager& mgr) const {
366360
mgr.incr_metric("kotlin_class", kotlin_class);
367361
mgr.incr_metric("Kotlin_anonymous_classes", kotlin_anonymous_class);
368362
mgr.incr_metric("kotlin_companion_class", kotlin_companion_class);
369-
mgr.incr_metric("di_generated_class", di_generated_class);
370363
mgr.incr_metric("kotlin_default_arg_method", kotlin_default_arg_method);
371364
mgr.incr_metric("kotlin_homonym_default_arg_method",
372365
kotlin_homonym_default_arg_method);
@@ -410,8 +403,6 @@ void PrintKotlinStats::Stats::report(PassManager& mgr) const {
410403
kotlin_anonymous_class);
411404
TRACE(KOTLIN_STATS, 1, "KOTLIN_STATS: kotlin_companion_class = %zu",
412405
kotlin_companion_class);
413-
TRACE(KOTLIN_STATS, 1, "KOTLIN_STATS: di_generated_class = %zu",
414-
di_generated_class);
415406
TRACE(KOTLIN_STATS, 1, "KOTLIN_STATS: kotlin_default_arg_method = %zu",
416407
kotlin_default_arg_method);
417408
TRACE(KOTLIN_STATS, 1,

opt/print-kotlin-stats/PrintKotlinStats.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ class PrintKotlinStats : public Pass {
4141
size_t kotlin_class{0};
4242
size_t kotlin_anonymous_class{0};
4343
size_t kotlin_companion_class{0};
44-
size_t di_generated_class{0};
4544
size_t kotlin_default_arg_method{0};
4645
// Methods that end with $default but are not Kotlin default arg methods.
4746
size_t kotlin_homonym_default_arg_method{0};
@@ -78,7 +77,6 @@ class PrintKotlinStats : public Pass {
7877
kotlin_class += that.kotlin_class;
7978
kotlin_anonymous_class += that.kotlin_anonymous_class;
8079
kotlin_companion_class += that.kotlin_companion_class;
81-
di_generated_class += that.di_generated_class;
8280
kotlin_default_arg_method += that.kotlin_default_arg_method;
8381
kotlin_homonym_default_arg_method +=
8482
that.kotlin_homonym_default_arg_method;
@@ -125,6 +123,5 @@ class PrintKotlinStats : public Pass {
125123
DexType* m_kotlin_lambdas_base = nullptr;
126124
DexType* m_kotlin_coroutin_continuation_base = nullptr;
127125
const DexString* m_instance = nullptr;
128-
DexType* m_di_base = nullptr;
129126
Stats m_stats;
130127
};

0 commit comments

Comments
 (0)