Enable base linters for flavors

agampe · meta-codesync[bot] · commit 73c4f40b2eb7 · 2026-02-17T11:07:03.000-08:00
Summary:
It is nice to have the formatter when promo diffs run into conflicts and the resolution isn't correctly indented and such.

Keep clang-tidy off for the moment, as that was decided before.

NOTE: Unclear what linters exactly now run, the format is just pretty garbage-y and illegible.

Fix the LICENSELINT config so it knows all Redex flavors are public. That is the one that I hit in a promo.

Reviewed By: xuhdev

Differential Revision: D92546103

fbshipit-source-id: 709710625f6c669f680fef7d49a700b2176d91f0
diff --git a/examples/ProguardExample/app/src/main/java/com/facebook/redex/examples/proguardexample/ui/theme/Theme.kt b/examples/ProguardExample/app/src/main/java/com/facebook/redex/examples/proguardexample/ui/theme/Theme.kt
@@ -27,7 +27,7 @@ private val LightColorScheme =
 fun MyApplicationTheme(
     darkTheme: Boolean = isSystemInDarkTheme(),
     dynamicColor: Boolean = true,
-    content: @Composable () -> Unit
+    content: @Composable () -> Unit,
 ) {
   val colorScheme =
       when {
diff --git a/examples/ProguardExample/app/src/main/java/com/facebook/redex/examples/proguardexample/ui/theme/Type.kt b/examples/ProguardExample/app/src/main/java/com/facebook/redex/examples/proguardexample/ui/theme/Type.kt
@@ -21,4 +21,6 @@ val Typography =
                 fontWeight = FontWeight.Normal,
                 fontSize = 16.sp,
                 lineHeight = 24.sp,
-                letterSpacing = 0.5.sp))
+                letterSpacing = 0.5.sp,
+            )
+    )
diff --git a/examples/Synth/app/src/main/java/com/facebook/redex/examples/synth/ui/theme/Theme.kt b/examples/Synth/app/src/main/java/com/facebook/redex/examples/synth/ui/theme/Theme.kt
@@ -27,7 +27,7 @@ private val LightColorScheme =
 fun MyApplicationTheme(
     darkTheme: Boolean = isSystemInDarkTheme(),
     dynamicColor: Boolean = true,
-    content: @Composable () -> Unit
+    content: @Composable () -> Unit,
 ) {
   val colorScheme =
       when {
diff --git a/examples/Synth/app/src/main/java/com/facebook/redex/examples/synth/ui/theme/Type.kt b/examples/Synth/app/src/main/java/com/facebook/redex/examples/synth/ui/theme/Type.kt
@@ -21,4 +21,6 @@ val Typography =
                 fontWeight = FontWeight.Normal,
                 fontSize = 16.sp,
                 lineHeight = 24.sp,
-                letterSpacing = 0.5.sp))
+                letterSpacing = 0.5.sp,
+            )
+    )
diff --git a/libredex/Creators.cpp b/libredex/Creators.cpp
@@ -677,7 +677,7 @@ MethodCreator::MethodCreator(DexMethodRef* ref,
                     ref->get_proto(),
                     access,
                     std::move(anno),
-                    with_debug_item){};
+                    with_debug_item) {};
 
 MethodCreator::MethodCreator(DexType* cls,
                              const DexString* name,
diff --git a/libredex/MethodProfiles.cpp b/libredex/MethodProfiles.cpp
@@ -433,8 +433,8 @@ void parse_manual_file(
     boost::split_regex(method_and_class, method_and_class_string,
                        boost::regex("->"));
     always_assert(method_and_class.size() == 1 || method_and_class.size() == 2);
-    manual_profile_lines.push_back({current_line, flags, method_and_class,
-                                     config_names, manual_filename});
+    manual_profile_lines.push_back(
+        {current_line, flags, method_and_class, config_names, manual_filename});
   }
 
   std::mutex unresolved_mutex;
diff --git a/libredex/RedexMappedFile.cpp b/libredex/RedexMappedFile.cpp
@@ -37,8 +37,9 @@ RedexMappedFile& RedexMappedFile::operator=(RedexMappedFile&& rhs) noexcept {
 
 RedexMappedFile RedexMappedFile::open(std::string path, bool read_only) {
   auto map = std::make_unique<boost::iostreams::mapped_file>();
-  std::ios_base::openmode mode = (std::ios_base::openmode)(
-      std::ios_base::in | (read_only ? 0 : std::ios_base::out));
+  std::ios_base::openmode mode =
+      (std::ios_base::openmode)(std::ios_base::in |
+                                (read_only ? 0 : std::ios_base::out));
   map->open(path, mode);
   if (!map->is_open()) {
     throw std::runtime_error(std::string("Could not map ") + path);
diff --git a/opt/outliner/OutlinerTypeAnalysis.cpp b/opt/outliner/OutlinerTypeAnalysis.cpp
@@ -822,9 +822,10 @@ const DexType* OutlinerTypeAnalysis::get_const_insns_type_demand(
   // 1. Let's see if we can get something out of the constant-uses analysis.
   constant_uses::TypeDemand type_demand{constant_uses::TypeDemand::None};
   for (const auto* insn : UnorderedIterable(const_insns)) {
-    type_demand = (constant_uses::TypeDemand)(
-        type_demand & m_constant_uses->get_constant_type_demand(
-                          const_cast<IRInstruction*>(insn)));
+    type_demand =
+        (constant_uses::TypeDemand)(type_demand &
+                                    m_constant_uses->get_constant_type_demand(
+                                        const_cast<IRInstruction*>(insn)));
     if (type_demand == constant_uses::TypeDemand::Error) {
       return nullptr;
     }
diff --git a/opt/reduce-array-literals/ReduceArrayLiterals.cpp b/opt/reduce-array-literals/ReduceArrayLiterals.cpp
@@ -22,8 +22,8 @@
 #include "DeterministicContainers.h"
 #include "IRCode.h"
 #include "IRInstruction.h"
-#include "LiveRange.h"
 #include "InterDexPass.h"
+#include "LiveRange.h"
 #include "PassManager.h"
 #include "Resolver.h"
 #include "Show.h"
diff --git a/opt/remove-unreachable/RemoveUnreachable.cpp b/opt/remove-unreachable/RemoveUnreachable.cpp
@@ -320,7 +320,8 @@ void RemoveUnreachablePassBase::run_pass(DexStoresVector& stores,
     auto uninstantiables_stats = reachability::sweep_uncallable_virtual_methods(
         stores, reachable_aspects);
     uninstantiables_stats.report(pm);
-    {}
+    {
+    }
   }
   if (should_sweep_annotation_elements()) {
     pm.incr_metric(
diff --git a/pyredex/bintools.py b/pyredex/bintools.py
@@ -262,7 +262,7 @@ def run_and_stream_stderr(
         )
 
     def stream_and_return(
-        line_handler: typing.Optional[typing.Callable[[str], str]] = None
+        line_handler: typing.Optional[typing.Callable[[str], str]] = None,
     ) -> typing.Tuple[int, typing.List[str]]:
         err_out: typing.List[str] = []
         # Copy and stash the output.
diff --git a/pyredex/packer.py b/pyredex/packer.py
@@ -297,7 +297,7 @@ def _warning_timer(name: str, threshold: float) -> typing.Generator[int, None, N
 
 
 def _compress(
-    data: typing.Tuple[CompressionEntry, str, str, argparse.Namespace]
+    data: typing.Tuple[CompressionEntry, str, str, argparse.Namespace],
 ) -> None:
     item, src_dir, trg_dir, args = data
     LOGGER.debug("Checking %s for compression...", item.name)
diff --git a/pyredex/utils.py b/pyredex/utils.py
@@ -28,7 +28,6 @@
 from os.path import basename, dirname, isfile, join
 
 import packaging.version
-
 from pyredex.logger import log
 
 
diff --git a/shared/file-utils.h b/shared/file-utils.h
@@ -16,7 +16,7 @@
 
 class FileHandle {
  public:
-  explicit FileHandle(FILE* fh) : bytes_written_(0), seek_ref_(0), fh_(fh){};
+  explicit FileHandle(FILE* fh) : bytes_written_(0), seek_ref_(0), fh_(fh) {};
   UNCOPYABLE(FileHandle);
 
   FILE* get() const { return fh_; }
diff --git a/test/instr/ClassMergingKotlinCoroutinesTestVerify.cpp b/test/instr/ClassMergingKotlinCoroutinesTestVerify.cpp
@@ -23,12 +23,13 @@ TEST_F(PostVerify, SinkCommonCtorInvocation) {
 
   auto* cls_coroutine_2 =
       is_kotlin_2_2_or_later
-          ? find_class_named(
-                classes,
-                "Lkotlin/sequences/SequencesKt___SequencesKt$runningFoldIndexed$1;")
+          ? find_class_named(classes,
+                             "Lkotlin/sequences/"
+                             "SequencesKt___SequencesKt$runningFoldIndexed$1;")
           : find_class_named(
                 classes,
-                "Lkotlin/sequences/SequencesKt___SequencesKt$runningReduceIndexed$1;");
+                "Lkotlin/sequences/"
+                "SequencesKt___SequencesKt$runningReduceIndexed$1;");
 
   verify_class_merged(cls_coroutine_1);
   verify_class_merged(cls_coroutine_2);
diff --git a/test/integ/MonotonicFixpointTest.cpp b/test/integ/MonotonicFixpointTest.cpp
@@ -116,8 +116,7 @@ TEST_F(MonotonicFixpointTest, livenessAnalysis) {
           code->build_cfg();
           cfg::ControlFlowGraph& cfg = code->cfg();
           cfg.calculate_exit_block();
-          std::cout << "CFG of function_1:" << "\n"
-                    << SHOW(cfg) << "\n";
+          std::cout << "CFG of function_1:" << "\n" << SHOW(cfg) << "\n";
           ASSERT_EQ(cfg.exit_block()->id(), 2);
           IRFixpointIterator fixpoint_iterator(cfg);
           fixpoint_iterator.run(LivenessDomain());
diff --git a/test/unit/LoopInfoTest.cpp b/test/unit/LoopInfoTest.cpp
@@ -59,10 +59,7 @@ TEST_F(LoopInfoTest, visit_depth_first) {
   }
 
   std::ostringstream check;
-  check << 1 << "\n"
-        << 2 << "\n"
-        << 34567 << "\n"
-        << 8 << "\n";
+  check << 1 << "\n" << 2 << "\n" << 34567 << "\n" << 8 << "\n";
   EXPECT_EQ(s.str(), check.str());
 }
 
diff --git a/test/unit/ResourceSerializationTest.cpp b/test/unit/ResourceSerializationTest.cpp
@@ -179,8 +179,7 @@ struct ParsedAaptOutput {
     }
     std::cerr << "\n"
               << "Dumping parsed package: " << package_name << "\n"
-              << "IDs (" << id_fully_qualified_names.size()
-              << "):" << "\n";
+              << "IDs (" << id_fully_qualified_names.size() << "):" << "\n";
     for (auto& pair : id_fully_qualified_names) {
       std::cerr << "  0x" << std::hex << pair.first << std::dec << " ("
                 << pair.second << ")" << "\n";
diff --git a/tools/common/Formatters.cpp b/tools/common/Formatters.cpp
@@ -18,8 +18,7 @@ struct type_to_string {
   const char* name;
 };
 
-#define GMAP_TYPE(NAME) \
-  { NAME, #NAME }
+#define GMAP_TYPE(NAME) {NAME, #NAME}
 type_to_string GMapTypes[] = {GMAP_TYPE(TYPE_HEADER_ITEM),
                               GMAP_TYPE(TYPE_STRING_ID_ITEM),
                               GMAP_TYPE(TYPE_TYPE_ID_ITEM),
