Build Failure: undefined reference to llvh::sys::MemoryFence()

[zxunge]

I'm not sure if this is my fault. I tried to build Hermes in Msys2 environment on a PC, but I've got this error when building:

[241/801] Linking CXX executable bin\hermesc.exe
FAILED: bin/hermesc.exe 
C:\Windows\system32\cmd.exe /C "cd . && D:\msys64\mingw32\bin\c++.exe -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -Wno-maybe-uninitialized -Wno-init-list-lifetime -Wno-redundant-move -Wno-deprecated-copy -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -ffp-contract=on -ffunction-sections -fdata-sections -fvisibility=hidden -g -Wl,--stack,16777216    -Wl,--gc-sections tools/hermesc/CMakeFiles/hermesc.dir/hermesc.cpp.obj -o bin\hermesc.exe -Wl,--out-implib,tools\hermesc\libhermesc.dll.a -Wl,--major-image-version,0,--minor-image-version,0  external/llvh/lib/Support/libLLVHSupport.a  lib/CompilerDriver/libhermesCompilerDriver.a  lib/AST/libhermesAST.a  lib/BCGen/HBC/libhermesHBCBackend.a  lib/BCGen/libhermesBackend.a  lib/Inst/libhermesInst.a  lib/libhermesOptimizer.a  lib/libhermesFrontend.a  lib/Parser/libhermesParser.a  lib/Support/libhermesSupport.a  lib/SourceMap/libhermesSourceMap.a  public/hermes/Public/libhermesPublic.a  lib/FrontEndDefs/libhermesFrontEndDefs.a  lib/Parser/libhermesParser.a  lib/ADT/libhermesADT.a  lib/AST2JS/libhermesAST2JS.a  lib/AST/libhermesAST.a  lib/Regex/libhermesRegex.a  lib/FlowParser/libhermesFlowParser.a  lib/Support/libhermesSupport.a  external/dtoa/libdtoa.a  lib/Platform/Unicode/libhermesPlatformUnicode.a  external/llvh/lib/Support/libLLVHSupport.a  external/llvh/lib/Demangle/libLLVHDemangle.a  D:/msys64/mingw32/lib/libicuuc.dll.a  D:/msys64/mingw32/lib/libicuin.dll.a  D:/msys64/mingw32/lib/libicudt.dll.a  D:/msys64/mingw32/lib/libicuuc.dll.a  D:/msys64/mingw32/lib/libicuin.dll.a  D:/msys64/mingw32/lib/libicudt.dll.a  external/zip/libzip.a  -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 && cd ."
D:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.2.0/../../../../i686-w64-mingw32/bin/ld.exe: external/llvh/lib/Support/libLLVHSupport.a(ManagedStatic.cpp.obj): in function `ZN4llvh9call_onceIRFvvEJEEEvRNS_9once_flagEOT_DpOT0_':
D:/a/Hermes/Hermes/hermes/external/llvh/include/llvh/Support/Threading.h:106:(.text$_ZN4llvh9call_onceIRFvvEJEEEvRNS_9once_flagEOT_DpOT0_[__ZN4llvh9call_onceIRFvvEJEEEvRNS_9once_flagEOT_DpOT0_]+0x1d): undefined reference to `llvh::sys::CompareAndSwap(unsigned int volatile*, unsigned int, unsigned int)'
D:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.2.0/../../../../i686-w64-mingw32/bin/ld.exe: D:/a/Hermes/Hermes/hermes/external/llvh/include/llvh/Support/Threading.h:109:(.text$_ZN4llvh9call_onceIRFvvEJEEEvRNS_9once_flagEOT_DpOT0_[__ZN4llvh9call_onceIRFvvEJEEEvRNS_9once_flagEOT_DpOT0_]+0x38): undefined reference to `llvh::sys::MemoryFence()'
D:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.2.0/../../../../i686-w64-mingw32/bin/ld.exe: D:/a/Hermes/Hermes/hermes/external/llvh/include/llvh/Support/Threading.h:117:(.text$_ZN4llvh9call_onceIRFvvEJEEEvRNS_9once_flagEOT_DpOT0_[__ZN4llvh9call_onceIRFvvEJEEEvRNS_9once_flagEOT_DpOT0_]+0x50): undefined reference to `llvh::sys::MemoryFence()'

D:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.2.0/../../../../i686-w64-mingw32/bin/ld.exe: D:/a/Hermes/Hermes/hermes/external/llvh/include/llvh/Support/Threading.h:120:(.text$_ZN4llvh9call_onceIRFvvEJEEEvRNS_9once_flagEOT_DpOT0_[__ZN4llvh9call_onceIRFvvEJEEEvRNS_9once_flagEOT_DpOT0_]+0x5f): undefined reference to `llvh::sys::MemoryFence()'

collect2.exe: error: ld returned 1 exit status

I've used the following commands as described:

cmake -S hermes -B build -G Ninja
cmake --build ./build

[tmikov]

Hi! It is great to see such experimentation in the community. A Mingw build is not something we support or test, so such errors are not very surprising.

For this specific error, adding the following code to /external/llvh/include/llvh/Support/Atomic.h might help, but there might be other problems.

#ifdef __GNUC__

namespace llvh::sys {
    inline void MemoryFence() {
      __sync_synchronize();
    }
    inline cas_flag CompareAndSwap(volatile cas_flag* ptr,
                            cas_flag new_value,
                            cas_flag old_value) {
      return __sync_val_compare_and_swap(ptr, old_value, new_value);
    }

}

#endif

I am converting this to discussion, since Mingw is not officially supported.

[zxunge]

Hi, thanks. Yes, adding those lines did work; however, to make it work under Windows using GCC, there're several other problems than that... I'm trying to find solutions for them all.

[tmikov]

Are the issues mostly around headers, system APIs, etc? We would be happy to receive a PR if they can be fixed reasonably.

[zxunge]

Now there's another problem I can't figure out (several other errors have been solved). In API/hermes_sandbox/external/wasm-rt-fb.h:81:

rand_s(&val1);

which causes an error error: implicit declaration of function 'rand_s'; did you mean 'rand'? [-Wimplicit-function-declaration].
I tried to add #define _CRT_RAND_S at the top of that file, but it didn't work.

[tmikov]

Do you need to build the sandbox? You can just exclude it from the build (though it certainly should be buildable in principle).

[zxunge]

Don't worry;
I think I've found a compromising solution to it.
Add the source of rand_s() from mingw-w64 to that file:

#if defined(__GNUC__) && defined(_WIN32)
#define _CRT_RAND_S
#include <stdlib.h>
#include <windows.h>
#include <ntsecapi.h>
#include <errno.h>

// msvcrt.h
//#ifndef __LIBMSVCRT_OS__
//#error "This file should only be used in libmsvcrt-os.a"
//#endif

#ifndef MSVCRT_H
#define MSVCRT_H

#include <winbase.h>

static inline HMODULE __mingw_get_msvcrt_handle(void)
{
    return GetModuleHandleA("msvcrt.dll");
}

#endif

static BOOLEAN (WINAPI *pRtlGenRandom)(void*,ULONG);

static errno_t mingw_rand_s(unsigned int *pval)
{
    return !pval || !pRtlGenRandom || !pRtlGenRandom(pval, sizeof(*pval)) ? EINVAL : 0;
}

static errno_t __cdecl init_rand_s(unsigned int*);

errno_t (__cdecl *__MINGW_IMP_SYMBOL(rand_s))(unsigned int*) = init_rand_s;

errno_t __cdecl
rand_s(unsigned int *val)
{
    return __MINGW_IMP_SYMBOL(rand_s)(val);
}

static errno_t __cdecl init_rand_s(unsigned int *val)
{
    int (__cdecl *func)(unsigned int*);

    func = (void*)GetProcAddress(__mingw_get_msvcrt_handle(), "rand_s");
    if(!func) {
        func = mingw_rand_s;
        pRtlGenRandom = (void*)GetProcAddress(LoadLibraryW(L"advapi32.dll"), "SystemFunction036");
    }

    return (__MINGW_IMP_SYMBOL(rand_s) = func)(val);
}
#endif

[zxunge]

A linking error has plagued me for long which I think might be the last error.

D:/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.2.0/../../../../i686-w64-mingw32/bin/ld.exe: lib/VM/libhermesVMRuntime.a(DateUtil.cpp.obj): in function `ZN6hermes2vm8localTZAEv':
D:/a/Hermes/Hermes/hermes/lib/VM/JSLib/DateUtil.cpp:223:(.text$_ZN6hermes2vm8localTZAEv+0x14): undefined reference to `_imp___get_timezone'

May get the _get_timezone function by linking msvcrxxx.dll, but that will add to the complexity of building and running...