Merge pull request #64 from ndaidong/v1.3.9

v1.3.9

Author: ndaidong

package.json

@@ -1,5 +1,5 @@
 {
-  "version": "1.3.8",
+  "version": "1.3.9",
   "name": "oembed-parser",
   "description": "Get oEmbed data from given URL.",
   "homepage": "https://www.npmjs.com/package/oembed-parser",
@@ -14,6 +14,7 @@
   },
   "scripts": {
     "lint": "eslint .",
+    "pretest": "npm run lint",
     "test": "jest --coverage=true",
     "eval": "node eval",
     "sync": "node sync",
@@ -23,7 +24,6 @@
     "node-fetch": "^2.6.0"
   },
   "devDependencies": {
-    "bellajs": "^8.0.2",
     "coveralls": "^3.1.0",
     "eslint-config-goes": "^1.1.8",
     "jest": "^26.0.1"

src/main.test.js

@@ -1,9 +1,5 @@
 // main
 
-const {
-  hasProperty,
-} = require('bellajs');
-
 const {
   extract,
   hasProvider,
@@ -36,6 +32,10 @@ const PhotoTypeKeys = [
   ...required,
 ];
 
+const hasProperty = (obj, key) => {
+  return Object.prototype.hasOwnProperty.call(obj, key);
+};
+
 const hasRichKeys = (o) => {
   return RichTypeKeys.every((k) => {
     return hasProperty(o, k);
@@ -68,7 +68,7 @@ const hasPhotoKeys = (o) => {
       try {
         await extract(url);
       } catch (err) {
-        expect(err instanceof Error).toBe(true);
+        expect(err).toBeTruthy();
       }
     });
   };
@@ -83,7 +83,7 @@ test(`test extract YouTube link`, async () => {
     const result = await extract(url);
     expect(hasRichKeys(result)).toBe(true);
   } catch (err) {
-    expect(err instanceof Error).toBe(null);
+    expect(err).toBe(null);
   }
 });
 
@@ -93,7 +93,7 @@ test(`test extract Flickr link`, async () => {
     const result = await extract(url);
     expect(hasPhotoKeys(result)).toBe(true);
   } catch (err) {
-    expect(err instanceof Error).toBe(null);
+    expect(err).toBe(null);
   }
 });
 
@@ -103,7 +103,7 @@ test(`test extract Flickr link with params`, async () => {
     const result = await extract(url, {maxwidth: 640, maxheight: 480});
     expect(hasPhotoKeys(result)).toBe(true);
   } catch (err) {
-    expect(err instanceof Error).toBe(null);
+    expect(err).toBe(null);
   }
 });