Skip to content

Commit f4fe98a

Browse files
JohnMcLearclaude
andcommitted
fix: replace stale ep_aa_file_menu_toolbar references with package name
After commits cc3314d/bdefdd2 renamed the package from ep_aa_file_menu_toolbar to ep_file_menu_toolbar, the eejs.require() calls in eejs.js and the $.getScript URL in static/js/index.js still pointed at the old name. Etherpad serves /static/plugins/<package>/... and resolves eejs.require('<package>/...') against the package's real path, both keyed by package.json name, so any user-visible click that triggered eejsBlock_body / eejsBlock_styles or loaded the toolbar script would 404 / fail to render. Also drop the README's instruction to clone into ep_aa_file_menu_toolbar - the modern plugin loader installs by package.json name, the aa_ prefix hack only mattered for legacy directory-name ordering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent efecdad commit f4fe98a

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
## Installation
88
Install using /admin/plugins
99
OR
10-
``git clone git@github.com:JohnMcLear/ep_file_menu_toolbar.git ep_aa_file_menu_toolbar``
10+
``git clone git@github.com:ether/ep_file_menu_toolbar.git``
1111

1212
## TODO
1313
* i18n support

eejs.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const eejs = require('ep_etherpad-lite/node/eejs/');
44

55
exports.eejsBlock_styles = (hookName, args, cb) => {
66
const css = eejs.require(
7-
'ep_aa_file_menu_toolbar/static/js/lib/jquery-css-dropdown-plugin-master/dropdown-menu.css',
7+
'ep_file_menu_toolbar/static/js/lib/jquery-css-dropdown-plugin-master/dropdown-menu.css',
88
{}, module,
99
);
1010
args.content = `${args.content}
@@ -13,7 +13,7 @@ exports.eejsBlock_styles = (hookName, args, cb) => {
1313
};
1414

1515
exports.eejsBlock_body = (hookName, args, cb) => {
16-
args.content = eejs.require('ep_aa_file_menu_toolbar/templates/toolbar.ejs', {
16+
args.content = eejs.require('ep_file_menu_toolbar/templates/toolbar.ejs', {
1717
settings: false,
1818
}) + args.content;
1919
cb();

static/js/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
exports.documentReady = () => {
44
/* eslint-disable-next-line max-len */
5-
$.getScript('../static/plugins/ep_aa_file_menu_toolbar/static/js/lib/jquery-css-dropdown-plugin-master/dropdown-menu.js', () => {
5+
$.getScript('../static/plugins/ep_file_menu_toolbar/static/js/lib/jquery-css-dropdown-plugin-master/dropdown-menu.js', () => {
66
$(() => {
77
$('.dropdown-menu').dropdown_menu({
88
open_delay: 50, // Delay on menu open

0 commit comments

Comments
 (0)