Use PowerShell as default shell on Windows & Fixes

* Use PowerShell as default on Windows if available to match behavior on
  Windows terminal.
* Fix Linting after update to rust 1.92

Author: AmmarAbouZor

application/apps/indexer/addons/shell-tools/src/lib.rs

@@ -42,6 +42,16 @@ fn load_shells() -> Vec<ShellProfile> {
     shells
 }
 
+#[cfg(windows)]
+/// Provides the path of built-in PowerShell on Windows, calculating it
+/// only on the very first call.
+pub fn get_win_powershell() -> Option<&'static std::path::PathBuf> {
+    use std::{path::PathBuf, sync::OnceLock};
+    static PATH: OnceLock<Option<PathBuf>> = std::sync::OnceLock::new();
+    PATH.get_or_init(|| which::which_global("powershell").ok())
+        .as_ref()
+}
+
 fn is_path_valid(shell: ShellType, path: &Path) -> bool {
     match shell {
         ShellType::Bash

application/apps/indexer/processor/src/search/error.rs

@@ -1,5 +1,4 @@
 use crate::grabber::GrabError;
-use log::error;
 use serde::Serialize;
 use thiserror::Error;
 

application/apps/indexer/session/src/tail/mod.rs

@@ -1,7 +1,6 @@
 //! Include functionalities for tailing files to send notifications once new
 //! data are written to the file.
 
-use log::error;
 use std::path::Path;
 use thiserror::Error as ThisError;
 use tokio::{

application/apps/indexer/sources/Cargo.toml

@@ -28,6 +28,7 @@ regex.workspace = true
 shellexpand = "3.1"
 stypes = { path = "../stypes", features=["rustcore"] }
 socket2 = "0.5.8"
+shell-tools = { path = "../addons/shell-tools" }
 
 [dev-dependencies]
 env_logger.workspace = true

application/apps/indexer/sources/src/command/process.rs

@@ -49,6 +49,15 @@ impl ProcessSource {
 
         let (bin, cmd_arg) = shell
             .map(|sh| (sh.path.as_os_str().to_os_string(), sh.shell.command_arg()))
+            // Check if built-in PowerShell is installed in use it as default shell.
+            .or_else(|| {
+                shell_tools::get_win_powershell().map(|p| {
+                    (
+                        p.as_os_str().to_os_string(),
+                        stypes::ShellType::Pwsh.command_arg(),
+                    )
+                })
+            })
             .unwrap_or_else(|| (OsString::from("cmd"), "/C"));
 
         Command::new(bin)