Skip to content

Make it possible to provide custom TCP options #173

@mentels

Description

@mentels

Such work has already been made in:

However I see a few issues here:

  • we allow to set the mode: {mode, Mode :: binary | list} - but this is wrong as escalus expect the received data to be binary (e.g. the calls erlang:byte_size/1 on it here
  • if would say the same is for active
  • we disable Nagle's algorithm by default {nodelay, true} but have we measured it helps us?
  • we set {reuseaddr, true} but we already know that setting this to true prevents us from squeezing ~50K users from one Amoc node

IMO that is to be fixed.

cc @erszcz, @michalwski @bszaf

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions