[BUG] Robot Advice crashes the app

[ehaar]

Component

Desktop App (Windows)

Performance Studio Version

1.19.1

Operating System

Windows 11

Describe the Bug

Clicking "Robot Advice" on a large execution plan (actually huge) crashes the app

Steps to Reproduce

1. Have a large execution plan opened (Actual or Estimated won't differ)
2. Click "Robot Advice"

Expected Behavior

A window with robot advice is expected

Actual Behavior

The app crashes totally

Plan File

To big to be anonimized, but find the error stack tree in the attached file:

StackTree.txt

Screenshots

No response

[erikdarlingdata]

Still open pending release, but one update worth recording here: #431 fixed the crash and missed a call site.

The ceiling was made a shared constant and applied to both Robot Advice entry points, the MCP tool options, and AnalyzeCommand's two option sets. QueryStoreCommand builds its own JsonOptions and CompactJsonOptions, identical in shape, and neither ever got MaxDepth. So planview querystore has kept failing on any plan deeper than ~30 operators the whole time analyze has been fine.

It fails quietly, which is why it went unnoticed: the per-plan try/catch in the sweep loop turns the JsonException into one ERROR: row in summary.txt and moves on, so a sweep over a few hundred Query Store plans silently analyzes all but the deep ones. Query Store batch analysis is exactly where deep plans live.

The lesson is in why it was missed, so the fix isn't two more MaxDepth = lines. A shared constant only helps the call sites that remember to reference it, and the options themselves were still duplicated per command — nothing anywhere said the two pairs were supposed to match. The options now live on AnalysisJson next to the constant and both commands point at them, and the test walks every *Command's options rather than trusting the next person to remember. Reverting the fix makes it fail by name: QueryStoreCommand.JsonOptions (MaxDepth 0), QueryStoreCommand.CompactJsonOptions (MaxDepth 0).

Branch is #438.