use new faction font color from api

Author: justinkb

MissionReportButtonPlus.lua

@@ -304,7 +304,7 @@ MRBP:SetScript("OnEvent", function(self, event, ...)
 			if majorFactionData then
 				local landingPageInfo = LandingPageInfo:GetLandingPageInfo(majorFactionData.expansionID);
 				local unlockedMessage = landingPageInfo.msg.majorFactionUnlocked;
-				local majorFactionColor = _G[strupper(majorFactionData.textureKit).."_MAJOR_FACTION_COLOR"];
+				local majorFactionColor = majorFactionData.factionFontColor and _G[majorFactionData.factionFontColor.baseTag] or NORMAL_FONT_COLOR;
 				unlockedMessage = unlockedMessage..TEXT_DASH_SEPARATOR..majorFactionColor:WrapTextInColorCode(majorFactionData.name);
 				ns.cprint(unlockedMessage);
 			end

data/majorfactions.lua

@@ -109,8 +109,7 @@ function LocalMajorFactionInfo:GetMajorFactionColor(majorFactionData, fallbackCo
 	local normalColor = fallbackColor or NORMAL_FONT_COLOR;
 
 	if (majorFactionData.expansionID >= ExpansionInfo.data.DRAGONFLIGHT.ID) then
-		local colorName = strupper(majorFactionData.textureKit).."_MAJOR_FACTION_COLOR";
-		return _G[colorName] or normalColor;
+		return majorFactionData.factionFontColor and _G[majorFactionData.factionFontColor.baseTag] or normalColor;
 	end
 
 	return normalColor;