Skip to content

feat: add ability to substitute media types for attachments #106#172

Merged
andrii-novikov merged 4 commits intodevelopmentfrom
feat/media-type-substitution
Mar 26, 2026
Merged

feat: add ability to substitute media types for attachments #106#172
andrii-novikov merged 4 commits intodevelopmentfrom
feat/media-type-substitution

Conversation

@andrii-novikov
Copy link
Contributor

@andrii-novikov andrii-novikov commented Mar 23, 2026

Applicable issues

Implements #106

Description of changes

Adds the ability to substitute attachment media types

Changes

  • New substitute_media_type utility in common/utils.py that maps attachment MIME types via a configurable dictionary
  • New media_type_substitution field on AttachmentConfig
  • Applied substitution in StagedBaseTool attachment pipeline — runs after supported_types filtering but before propagate_types_to_choice check, so propagation uses the substituted type

Checklist

  • Title of the pull request follows Conventional Commits specification
  • Documentation is updated/created (if applicable)
  • Changes are tested on review environment
  • App schema changes are backward compatible
  • Integration tests pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andrii-novikov andrii-novikov force-pushed the feat/media-type-substitution branch 2 times, most recently from 0915e6a to f563055 Compare March 23, 2026 13:31
@ypldan ypldan marked this pull request as ready for review March 24, 2026 07:04
@ypldan ypldan self-requested a review as a code owner March 24, 2026 07:04
@ypldan ypldan requested review from VinShurik and removed request for ypldan March 25, 2026 09:18
@andrii-novikov andrii-novikov force-pushed the feat/media-type-substitution branch from a380329 to 08a34bc Compare March 25, 2026 15:09
@andrii-novikov
Copy link
Contributor Author

andrii-novikov commented Mar 25, 2026

/deploy-review

GitHub actions run: 23548439724

Stage Status
deploy-review Success ✅
matrix.application Skipped ➖

@VinShurik
Copy link
Collaborator

add (#106) to title

@andrii-novikov andrii-novikov changed the title feat: add ability to substitute media types for attachments feat: add ability to substitute media types for attachments #106 Mar 26, 2026
@andrii-novikov andrii-novikov enabled auto-merge (squash) March 26, 2026 16:11
@andrii-novikov andrii-novikov merged commit 91d0020 into development Mar 26, 2026
8 checks passed
@andrii-novikov andrii-novikov deleted the feat/media-type-substitution branch March 26, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants