Skip to content

fix: attachment notifications wording #131#130

Merged
ypldan merged 4 commits intodevelopmentfrom
fix/attachment-notifications-wording
Mar 2, 2026
Merged

fix: attachment notifications wording #131#130
ypldan merged 4 commits intodevelopmentfrom
fix/attachment-notifications-wording

Conversation

@ypldan
Copy link
Collaborator

@ypldan ypldan commented Mar 2, 2026

Applicable issues

Description of changes

Improve how attachment metadata is communicated to the LLM agent:

  • XML format for attachment notifications: Replace plain-text attachment metadata with structured <attachments> XML, making it clearer these are user-provided files (for those that are in user msgs) and easier for the LLM to parse.
  • Conditional reference_url: Only include <reference_url> element when the value is present, instead of rendering None.
  • Clarified available_context tool description: Explicitly state the tool is for admin-configured context only and does not cover attached files, referencing the <attachments> section.
  • Expanded test coverage: Added multi-message, role-based (assistant/tool), and edge case tests for _AttachmentFilter.

Checklist

  • Title of the pull request follows Conventional Commits specification
  • Documentation is updated/created (if applicable)
  • Changes are tested on review environment
  • Integration tests pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ypldan ypldan requested a review from korotaav48 March 2, 2026 12:54
@ypldan ypldan self-assigned this Mar 2, 2026
@ypldan ypldan added bug Something isn't working python Pull requests that update python code labels Mar 2, 2026
@ypldan ypldan changed the title fix: attachment notifications wording fix: attachment notifications wording #131 Mar 2, 2026
@ypldan
Copy link
Collaborator Author

ypldan commented Mar 2, 2026

/deploy-review

GitHub actions run: 22577540431

Stage Status
deploy-review Success ✅
matrix.application Skipped ➖

korotaav48
korotaav48 previously approved these changes Mar 2, 2026
@ypldan
Copy link
Collaborator Author

ypldan commented Mar 2, 2026

/deploy-review

GitHub actions run: 22580899812

Stage Status
deploy-review Success ✅
matrix.application Skipped ➖

@ypldan ypldan requested a review from korotaav48 March 2, 2026 15:39
@ypldan ypldan merged commit 3964ab4 into development Mar 2, 2026
9 checks passed
@ypldan ypldan deleted the fix/attachment-notifications-wording branch March 2, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attached file becomes unavailable after deleting one of them

2 participants