treewide: go fix

Author: katexochen

internal/cryptsetup/cryptsetup.go

@@ -319,7 +319,7 @@ type cryptsetupMetadata struct {
 			JournalEncryption string `json:"journal_encryption"`
 			JournalIntegrity  string `json:"journal_integrity"`
 			KeySize           int    `json:"key_size"`
-		} `json:"integrity,omitempty"`
+		} `json:"integrity"`
 	} `json:"segments"`
 	Digests map[string]struct {
 		Type       string   `json:"type"`

internal/kuberesource/parts.go

@@ -6,6 +6,7 @@ package kuberesource
 import (
 	"fmt"
 	"strconv"
+	"strings"
 
 	"github.com/edgelesssys/contrast/internal/manifest"
 	"github.com/edgelesssys/contrast/internal/platforms"
@@ -216,14 +217,14 @@ func PortForwarder(name, namespace string) *PortForwarderConfig {
 // WithListenPorts sets multiple ports to listen on.
 func (p *PortForwarderConfig) WithListenPorts(ports []int32) *PortForwarderConfig {
 	var containerPorts []*applycorev1.ContainerPortApplyConfiguration
-	var envVar string
+	var envVar strings.Builder
 	for _, port := range ports {
 		containerPorts = append(containerPorts, ContainerPort().WithContainerPort(port))
-		envVar += " " + strconv.Itoa(int(port))
+		envVar.WriteString(" " + strconv.Itoa(int(port)))
 	}
 	p.Spec.Containers[0].
 		WithPorts(containerPorts...).
-		WithEnv(NewEnvVar("LISTEN_PORTS", envVar))
+		WithEnv(NewEnvVar("LISTEN_PORTS", envVar.String()))
 	return p
 }
 

internal/logger/handler.go

@@ -90,7 +90,7 @@ func subsystemAllowListMatch(subsystem string, allowList string) bool {
 	if allowList == "*" {
 		return true
 	}
-	for _, allow := range strings.Split(allowList, ",") {
+	for allow := range strings.SplitSeq(allowList, ",") {
 		allow = strings.ToLower(strings.TrimSpace(allow))
 		if allow == subsystem || allow == "*" {
 			return true

service-mesh/config.go

@@ -120,7 +120,7 @@ func ParseProxyConfig(ingressConfig, egressConfig, adminPort string) (ProxyConfi
 		return cfg, nil
 	}
 
-	for _, entry := range strings.Split(ingressConfig, "##") {
+	for entry := range strings.SplitSeq(ingressConfig, "##") {
 		if entry == "" {
 			continue
 		}

tools/tdx-measure/eventlog/mrtd.go

@@ -27,12 +27,12 @@ func NewMrtdLogger(dir string) *MrtdLogger {
 
 // MemPageAdd logs a TDH_MEM_PAGE_ADD event for the given GPA.
 func (l *MrtdLogger) MemPageAdd(gpa uint64) {
-	l.log([]byte(fmt.Sprintf("TDH_MEM_PAGE_ADD gpa=0x%x\n", gpa)))
+	l.log(fmt.Appendf(nil, "TDH_MEM_PAGE_ADD gpa=0x%x\n", gpa))
 }
 
 // MrExtend logs a TDH_MR_EXTEND event for the given GPA.
 func (l *MrtdLogger) MrExtend(gpa uint64) {
-	l.log([]byte(fmt.Sprintf("TDH_MR_EXTEND gpa=0x%x\n", gpa)))
+	l.log(fmt.Appendf(nil, "TDH_MR_EXTEND gpa=0x%x\n", gpa))
 }
 
 // SaveToFile writes the `TDH_MR_FINALIZE` event and saves the event log