Skip to content

Wrong lang attribute on html node, when locale is set to anything other than 'en' #16968

@Alexander-Taran

Description

@Alexander-Taran

Bug Description:

lang attribute is defined as 'en' in generated index.html

It confuses google translate plugin into translating UI in different locales as if they were in English.
Since we already have everything in place to properly localize UI, we might be better off discouraging browser plugins from translating with additional attributes. And also set a proper lang attribute on html node.

Steps to Reproduce:

  1. Open web app
  2. Change locale to something other than English
  3. Use chromes translate plugin to translate to same language. (Users can have it set to auto)

here's a PR with "fixes"
#16966

Metadata

Metadata

Assignees

No one assigned

    Labels

    localizationissues related to localization/internalization/nls

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions