In RAP, menu creation (menuAboutToShow) happens first, then MenuDetectListener

[zev333]

In RCP, MenuDetectListener fires first, then menu creation (menuAboutToShow). In RAP, menu creation happens first, then MenuDetectListener.
This causes the menu to be created for the previous tab item instead of the current one, for the same reason it is not possible to block menu creation by setting "e.doit = false" in MenuDetectListener so tab menu appeaser for elements in tab together with tab menu.

Snippet attached.

eclipe-menu-snippet.zip

[ifurnadjiev]

Could you please give the PR a try? As this PR changes the order of Show and MenuDetect typed events (move Show after MenuDetect ), I'm not sure if it brakes something else or not. Before SWT.Show events was fired before:

    SWT.Dispose,
    SWT.SetData,
    SWT.Traverse,
    SWT.FocusOut,
    SWT.FocusIn,
    SWT.KeyDown,
    SWT.Expand,
    SWT.Collapse,
    SWT.Verify,
    SWT.Modify,
    SWT.MouseDown,
    SWT.MouseDoubleClick,

and now after these events.

[zev333]

For regular elements like Label it works in expected order so we can count this bug as fixed.

We still have 2 more issues (I think both should be opened as a separate bugs, correct me if I'm wrong):

1. e.doit is ignored when set to false - menu is still opened

        label.addMenuDetectListener((e) -> {
            e.doit = false;
        });

2. Menu for org.eclipse.swt.custom.CTabFolder is opened on MouseDown, not on the MouseUp so addMenuDetectListener is not called at all.

[ifurnadjiev]

e.doit = false; is not supported in RAP since many years as it requires synchronous requests, which are deprecated on some browsers and completely removed on other.

[zev333]

Thank you for clarification!

I've created second issue as a separate one: #350