Skip to content

Commit 350e504

Browse files
committed
toast-dialog: moved live region to wrapper
1 parent 292e4ff commit 350e504

1 file changed

Lines changed: 19 additions & 17 deletions

File tree

_messaging/toast-dialog/index.html

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -13,24 +13,26 @@ <h2>Example 1</h2>
1313

1414
<button class="btn btn--primary dialog-button" type="button" data-makeup-for="dialog-toast" aria-haspopup="dialog">Open Toast Dialog</button>
1515

16-
<aside id="dialog-toast" class="toast-dialog" role="dialog" aria-label="Notification" aria-live="polite" aria-modal="false" hidden>
17-
<div class="toast-dialog__window">
18-
<div class="toast-dialog__header">
19-
<h2 class="toast-dialog__title">User Privacy Preferences</h2>
20-
<button class="icon-btn icon-btn--transparent toast-dialog__close" type="button" aria-label="Close dialog">
21-
<svg class="icon icon--16" focusable="false" height="24" width="24">
22-
<use xlink:href="../../static/icons.svg#icon-close-16"></use>
23-
</svg>
24-
</button>
16+
<div role="status">
17+
<aside id="dialog-toast" class="toast-dialog" role="dialog" aria-label="Notification" aria-modal="false" hidden>
18+
<div class="toast-dialog__window">
19+
<div class="toast-dialog__header">
20+
<h2 class="toast-dialog__title">User Privacy Preferences</h2>
21+
<button class="icon-btn icon-btn--transparent toast-dialog__close" type="button" aria-label="Close dialog">
22+
<svg class="icon icon--16" focusable="false" height="24" width="24">
23+
<use xlink:href="../../static/icons.svg#icon-close-16"></use>
24+
</svg>
25+
</button>
26+
</div>
27+
<div class="toast-dialog__main">
28+
<p>We detected something unusual about a recent sign-in to your account. To help keep you safe, we recommend you change the password.</p>
29+
</div>
30+
<div class="toast-dialog__footer">
31+
<a accesskey="v" class="toast-dialog__cta" href="http://www.ebay.com">View Account</a>
32+
</div>
2533
</div>
26-
<div class="toast-dialog__main">
27-
<p>We detected something unusual about a recent sign-in to your account. To help keep you safe, we recommend you change the password.</p>
28-
</div>
29-
<div class="toast-dialog__footer">
30-
<a accesskey="v" class="toast-dialog__cta" href="http://www.ebay.com">View Account</a>
31-
</div>
32-
</div>
33-
</aside>
34+
</aside>
35+
</div>
3436

3537
<hr />
3638

0 commit comments

Comments
 (0)