Skip to content

Whippet gets confused if both main and master exist #188

@RobjS

Description

@RobjS

To recreate:

  • Create a new plugin repo, with both main and master branches. Make master the default
  • Push an older version of the plugin to main, and a newer version to master (i.e. so that the older version does not exist on the commit history of main)
  • Point your whippet.json file at that repo (with no specific reference beyond the repo source)
  • Run whippet deps update. Whippet will take the commit hash reference added to whippet.lock from main, but try and pull the plugin from master, using that reference. This will result in a fatal: reference is not a tree: [commit-hash-from-master] error when running whippet deps install or whippet deps update

It appears that, if main exists, Whippet assumes it's the default branch, but that may not actually be the case. It should probably just use the default branch at all times, and allow that default branch to be either main or master.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions