Skip to content

Commit 981d427

Browse files
authored
Merge pull request #3 from duffn/duffn/null-function-tests
Add tests for null params for inclusion and exclusion fuctions
2 parents 96b81b6 + bdfdecb commit 981d427

File tree

4 files changed

+62
-2
lines changed

4 files changed

+62
-2
lines changed

src/vtc/null_params_exclusion.vtc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
varnishtest "Test querymodifier vmod for partial non-matches"
1+
varnishtest "Test querymodifier vmod for null params exclusion"
22

33
server s1 {
44
rxreq
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
varnishtest "Test querymodifier vmod for null params using the excludeparams function"
2+
3+
server s1 {
4+
rxreq
5+
txresp -body "OK1"
6+
expect req.url == "/feed/"
7+
} -start
8+
9+
varnish v1 -vcl+backend {
10+
import std;
11+
import querymodifier;
12+
13+
sub vcl_recv {
14+
std.syslog(180, "querymodifier before: " + req.url);
15+
set req.url = querymodifier.excludeparams(url=req.url, params="");
16+
std.syslog(180, "querymodifier after: " + req.url);
17+
}
18+
} -start
19+
20+
client c1 {
21+
txreq -url "/feed/?id=1&d=2&another=3"
22+
rxresp
23+
expect resp.status == 200
24+
} -run
25+
26+
varnish v1 -expect n_object == 1
27+
varnish v1 -expect cache_miss == 1
28+
varnish v1 -expect cache_hit == 0

src/vtc/null_params_inclusion.vtc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
varnishtest "Test querymodifier vmod for partial non-matches"
1+
varnishtest "Test querymodifier vmod for null params inclusion"
22

33
server s1 {
44
rxreq
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
varnishtest "Test querymodifier vmod for null params using the includeparams function"
2+
3+
server s1 {
4+
rxreq
5+
txresp -body "OK1"
6+
expect req.url == "/feed/"
7+
} -start
8+
9+
varnish v1 -vcl+backend {
10+
import std;
11+
import querymodifier;
12+
13+
sub vcl_recv {
14+
std.syslog(180, "querymodifier before: " + req.url);
15+
set req.url = querymodifier.includeparams(url=req.url, params="");
16+
std.syslog(180, "querymodifier after: " + req.url);
17+
}
18+
} -start
19+
20+
client c1 {
21+
txreq -url "/feed/?id=1&d=2&another=3"
22+
rxresp
23+
expect resp.status == 200
24+
25+
txreq -url "/feed/"
26+
rxresp
27+
expect resp.status == 200
28+
} -run
29+
30+
varnish v1 -expect n_object == 1
31+
varnish v1 -expect cache_miss == 1
32+
varnish v1 -expect cache_hit == 1

0 commit comments

Comments
 (0)