Skip to content

Commit aa3e1c8

Browse files
authored
Fix failing bookmark tests (#7720)
Task/Issue URL: https://app.asana.com/1/137249556945/task/1213210377163129 ### Description * Don't try to open context menu until bookmark added botomSheet has disappeared ### Steps to test this PR _Feature 1_ - [ ] [Release tests](https://app.maestro.dev/project/proj_01htg54rdtfwx8rgbzv03cxkpf/maestro-test/app/app_01hkqhj1thevwtn9ym8a2ctn2r/upload/mupload_01kh6eembtfm6vpmdhhfptas7c?sort=name) are passing on Maestro ### UI changes n/a <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test-only timing change; no production code or data flows are modified, with minimal risk beyond potentially masking a real UI hang if the prompt never dismisses. > > **Overview** > Stabilizes the Maestro release tests for adding/removing favorites from bookmarks by inserting an `extendedWaitUntil` step after tapping **add bookmark**. > > Both `favorites_bookmarks_add.yaml` and `favorites_bookmarks_delete.yaml` now wait up to 5s for the "Bookmark added" bottom-sheet/prompt to disappear before reopening the menu and continuing, reducing flakiness from UI timing/race conditions. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 45dd0d9. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent a2df6b2 commit aa3e1c8

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

.maestro/favorites/favorites_bookmarks_add.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ tags:
1919
- runFlow: ../shared/browser_screen/click_on_menu_button.yaml
2020
- tapOn:
2121
text: "add bookmark"
22+
# Wait for prompt to disappear
23+
- extendedWaitUntil:
24+
notVisible:
25+
text: "Bookmark added.*"
26+
timeout: 5000
2227
# Navigate to bookmarks screen
2328
- runFlow: ../shared/browser_screen/click_on_menu_button.yaml
2429
- tapOn:

.maestro/favorites/favorites_bookmarks_delete.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ tags:
2121
text: "add bookmark"
2222
- tapOn:
2323
text: "add bookmark"
24+
# Wait for prompt to disappear
25+
- extendedWaitUntil:
26+
notVisible:
27+
text: "Bookmark added.*"
28+
timeout: 5000
2429
# Add favorite from edit saved site
2530
- runFlow: ../shared/browser_screen/click_on_menu_button.yaml
2631
- assertVisible:

0 commit comments

Comments
 (0)