Skip to content

Commit 21d61b3

Browse files
authored
Add pixel definition for sync rescope API error (#7607)
Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1213002272473269?focus=true ### Description Adds pixel definition for pixel (`m_sync_rescope_token_error`) which can fire if the `rescope` API errors inside sync. ### Steps to test this PR - QA optional <!-- CURSOR_SUMMARY --> --- > [!NOTE] > <sup>[Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) is generating a summary for commit 6d626a3. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Craig Russell <1336281+CDRussell@users.noreply.github.com>
1 parent 4a4b01d commit 21d61b3

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

PixelDefinitions/pixels/sync_promotion.json5 renamed to PixelDefinitions/pixels/sync.json5

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,24 @@
1919
"triggers": ["other"],
2020
"suffixes": ["form_factor"],
2121
"parameters": ["appVersion"]
22+
},
23+
"m_sync_rescope_token_error": {
24+
"description": "Fired when rescoping the sync token fails",
25+
"owners": ["CDRussell"],
26+
"triggers": ["other"],
27+
"suffixes": ["form_factor"],
28+
"parameters": [
29+
"appVersion",
30+
{
31+
"key": "code",
32+
"description": "The error code returned from the sync service",
33+
"type": "string"
34+
},
35+
{
36+
"key": "reason",
37+
"description": "The reason for the rescope token failure",
38+
"type": "string"
39+
}
40+
]
2241
}
2342
}

sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/pixels/SyncPixels.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -513,6 +513,7 @@ object SyncPixelsRequiringDataCleaning : PixelParamRemovalPlugin {
513513
SyncPixelName.SYNC_SETUP_PROMO_BOOKMARK_ADDED_DIALOG_SHOWN.pixelName to removeAtb(),
514514
SyncPixelName.SYNC_SETUP_PROMO_BOOKMARK_ADDED_DIALOG_DISMISSED.pixelName to removeAtb(),
515515
SyncPixelName.SYNC_SETUP_PROMO_BOOKMARK_ADDED_DIALOG_CONFIRMED.pixelName to removeAtb(),
516+
SyncPixelName.SYNC_RESCOPE_TOKEN_FAILURE.pixelName to removeAtb(),
516517
)
517518
}
518519
}

0 commit comments

Comments
 (0)