fixes

audio fixes to reduce skipping, ui fixes using nesting in hstack vstack instead of custom constraints,  increasing ui speed reducing constraint glitches, flatter layout, some buttons removed.
 - Audio pipeline (Sources/AudioStreamer/AudioStreamer.m, HermesTests/AudioStreamerRetryTests.m, docs): removed the legacy state-controller glue, made the state controller mandatory, added ADTS fallback,
    startup buffering, and strict content-length handling so retries happen before Core Audio plays truncated data. Tests were updated to cover the retry bookkeeping.
  - UI/layout (Resources/Base.lproj/MainMenu.xib): rewrote the playback view using nested NSStackViews, removed the ad-hoc fixed widths that caused constraint spam, added explicit widths/minimums for the
    playback stack/history pane, wrapped the album art so it stays square, and anchored the station list/history stacks so they don’t resize when cover art loads.
  - Hover fields (Sources/Views/LabelHoverShowFieldCell.m): fixed the custom cell to only subtract the hover overlay’s width when it’s visible, so artist/title/album labels no longer clip to a single
    word.

  Put together, this commit keeps Auto Layout stable (no more “Unable to satisfy constraints” flurries), the hover labels show full text, the history view shows complete rows, and AudioStreamer handles
  corrupted AAC chunks by buffering/retrying instead of glitching.
  AudioStreamer: remove legacy glue, add ADTS fallback & startup buffer
  UI: rebuilt playback pane with stack views, fixed hover labels, stabilize album art

Author: dtseto

Documentation/AudioStreamerStateControllerRefactor.md

@@ -8,11 +8,10 @@ The XCTest coverage for the controller lives in `Sources/AudioStreamer/AudioStre
 
 ### Migration notes
 
-- `AudioStreamer` now instantiates `AudioStreamerStateController` but retains the legacy logic as a fallback (`legacyTransitionToState:` and `handleFailureSynchronouslyWithCode:`) to guarantee behaviour matches older builds even if the controller is unavailable. This preserves backwards compatibility and makes reversion simple.
+- `AudioStreamer` now instantiates `AudioStreamerStateController` and requires it for all state transitions. Retry bookkeeping (like clearing transient counters) still lives in `AudioStreamer`, but the controller owns notification fan-out and thread hopping so there is only one codepath to audit.
 - `failWithErrorCode:` routes through the controller for thread-hopping but the error-code gating still occurs inside `AudioStreamer`, which keeps existing error semantics intact.
 - Tests sit alongside the production sources because the sandbox prevented creating a dedicated `Tests/` directory. They can be moved into a formal test target as part of integration.
 
 ### Reverting
 
-To revert the change, remove `AudioStreamerStateController.{h,m}` and the associated test file, delete the helper import/property from `AudioStreamer.m`, and restore the original `setState:` and `failWithErrorCode:` implementations (now preserved in `legacyTransitionToState:` and `handleFailureSynchronouslyWithCode:`). The project file entries for the controller can then be dropped to return to the prior build graph.
-
+To revert the change, remove `AudioStreamerStateController.{h,m}` and the associated test file, delete the helper import/property from `AudioStreamer.m`, and restore the original `setState:` and `failWithErrorCode:` implementations that used to live inline (including the notification/distributed notification plumbing). The project file entries for the controller can then be dropped to return to the prior build graph.

Hermes.xcodeproj/project.pbxproj

@@ -628,7 +628,7 @@
 			attributes = {
 				BuildIndependentTargetsInParallel = YES;
 				LastSwiftUpdateCheck = 1640;
-				LastUpgradeCheck = 1610;
+				LastUpgradeCheck = 1640;
 				TargetAttributes = {
 					0F795D212EB6F1870009B05D = {
 						CreatedOnToolsVersion = 16.4;
@@ -809,7 +809,6 @@
 				CODE_SIGN_STYLE = Automatic;
 				CURRENT_PROJECT_VERSION = 1;
 				DEBUG_INFORMATION_FORMAT = dwarf;
-				DEVELOPMENT_TEAM = GHTQCRGWTR;
 				GCC_C_LANGUAGE_STANDARD = gnu17;
 				GCC_DYNAMIC_NO_PIC = NO;
 				GCC_PREPROCESSOR_DEFINITIONS = (
@@ -820,7 +819,7 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GENERATE_INFOPLIST_FILE = YES;
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
-				MACOSX_DEPLOYMENT_TARGET = 11.5;
+				MACOSX_DEPLOYMENT_TARGET = 11.0;
 				MARKETING_VERSION = 1.0;
 				MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
 				MTL_FAST_MATH = YES;
@@ -852,14 +851,13 @@
 				CODE_SIGN_STYLE = Automatic;
 				CURRENT_PROJECT_VERSION = 1;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
-				DEVELOPMENT_TEAM = GHTQCRGWTR;
 				ENABLE_NS_ASSERTIONS = NO;
 				GCC_C_LANGUAGE_STANDARD = gnu17;
 				GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GENERATE_INFOPLIST_FILE = YES;
 				LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
-				MACOSX_DEPLOYMENT_TARGET = 11.5;
+				MACOSX_DEPLOYMENT_TARGET = 11.0;
 				MARKETING_VERSION = 1.0;
 				MTL_ENABLE_DEBUG_INFO = NO;
 				MTL_FAST_MATH = YES;
@@ -884,7 +882,6 @@
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
 				DEAD_CODE_STRIPPING = YES;
-				DEVELOPMENT_TEAM = GHTQCRGWTR;
 				ENABLE_HARDENED_RUNTIME = YES;
 				ENABLE_PREVIEWS = YES;
 				FRAMEWORK_SEARCH_PATHS = (
@@ -908,7 +905,7 @@
 				);
 				LLVM_LTO = YES_THIN;
 				MACOSX_DEPLOYMENT_TARGET = 11.0;
-				MARKETING_VERSION = 2.0.0b1;
+				MARKETING_VERSION = 2.0.0b2;
 				ONLY_ACTIVE_ARCH = YES;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.alexcrichton.$(PRODUCT_NAME:rfc1034identifier)";
 				PRODUCT_NAME = Hermes;
@@ -935,7 +932,6 @@
 				COMBINE_HIDPI_IMAGES = YES;
 				DEAD_CODE_STRIPPING = YES;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
-				DEVELOPMENT_TEAM = GHTQCRGWTR;
 				ENABLE_HARDENED_RUNTIME = YES;
 				ENABLE_PREVIEWS = YES;
 				ENABLE_TESTABILITY = YES;
@@ -961,7 +957,7 @@
 				);
 				LLVM_LTO = YES_THIN;
 				MACOSX_DEPLOYMENT_TARGET = 11.0;
-				MARKETING_VERSION = 2.0.0b1;
+				MARKETING_VERSION = 2.0.0b2;
 				ONLY_ACTIVE_ARCH = YES;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.alexcrichton.$(PRODUCT_NAME:rfc1034identifier)";
 				PRODUCT_NAME = Hermes;
@@ -1004,6 +1000,7 @@
 				COPY_PHASE_STRIP = NO;
 				CURRENT_PROJECT_VERSION = 2059;
 				DEAD_CODE_STRIPPING = YES;
+				DEVELOPMENT_TEAM = GHTQCRGWTR;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				ENABLE_TESTABILITY = YES;
 				ENABLE_USER_SCRIPT_SANDBOXING = YES;
@@ -1056,6 +1053,7 @@
 				COPY_PHASE_STRIP = NO;
 				CURRENT_PROJECT_VERSION = 2059;
 				DEAD_CODE_STRIPPING = YES;
+				DEVELOPMENT_TEAM = GHTQCRGWTR;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				ENABLE_USER_SCRIPT_SANDBOXING = YES;
 				EXCLUDED_ARCHS = "";
@@ -1073,6 +1071,7 @@
 				MACOSX_DEPLOYMENT_TARGET = 11.5;
 				ONLY_ACTIVE_ARCH = YES;
 				SDKROOT = macosx;
+				SWIFT_COMPILATION_MODE = wholemodule;
 				VERSIONING_SYSTEM = "apple-generic";
 				WARNING_CFLAGS = "-Wall";
 			};

Hermes.xcodeproj/xcshareddata/xcschemes/Archive Hermes.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1610"
+   LastUpgradeVersion = "1640"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

Hermes.xcodeproj/xcshareddata/xcschemes/Hermes (Release — media keys enabled).xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1610"
+   LastUpgradeVersion = "1640"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

Hermes.xcodeproj/xcshareddata/xcschemes/Hermes.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1610"
+   LastUpgradeVersion = "1640"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

Hermes.xcodeproj/xcshareddata/xcschemes/Upload Hermes Release.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1610"
+   LastUpgradeVersion = "1640"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

HermesTests/AudioStreamerRetryTests.m

@@ -91,4 +91,27 @@ - (void)testRetryExhaustionTriggersFinalFailure {
   XCTAssertEqual(streamer.startInvocationCount, 2U);
 }
 
+- (void)testStateTransitionsResetRetryBookkeeping {
+  TestRetryAudioStreamer *streamer = [[TestRetryAudioStreamer alloc] init];
+  [streamer setValue:@3 forKey:@"retryAttemptCount"];
+  [streamer setValue:@YES forKey:@"retryScheduled"];
+  [streamer setValue:@(12.5) forKey:@"retryResumeTime"];
+  [streamer setValue:@(AS_WAITING_FOR_DATA) forKey:@"state_"];
+
+  SEL setStateSEL = NSSelectorFromString(@"setState:");
+  ((void (*)(id, SEL, AudioStreamerState))objc_msgSend)(streamer, setStateSEL, AS_PLAYING);
+
+  XCTAssertEqual(streamer.retryAttemptCount, 0U);
+  XCTAssertFalse(streamer.retryScheduled);
+  XCTAssertEqual(streamer.retryResumeTime, 0.0);
+
+  [streamer setValue:@YES forKey:@"retryScheduled"];
+  [streamer setValue:@(8.0) forKey:@"retryResumeTime"];
+
+  ((void (*)(id, SEL, AudioStreamerState))objc_msgSend)(streamer, setStateSEL, AS_STOPPED);
+
+  XCTAssertFalse(streamer.retryScheduled);
+  XCTAssertEqual(streamer.retryResumeTime, 0.0);
+}
+
 @end