Skip to content

Commit ea0f764

Browse files
committed
fix: remove dead SLF4J imports, add NOP binding to target
Remove unused Import-Package: org.slf4j from 4 test bundle manifests: - com.avaloq.tools.ddk.check.ui.test - com.avaloq.tools.ddk.test.ui - com.avaloq.tools.ddk.xtext.test - com.avaloq.tools.ddk.xtext.test.core No Java or Xtend source file in the entire DDK codebase references org.slf4j — these were stale declarations. Add org.slf4j.binding.nop 1.7.30 to the target platform (from the same Eclipse Orbit repo that already provides org.slf4j.ext). This provides the SLF4J 1.7.x StaticLoggerBinder that Xtext's transitive slf4j.api bundle looks for at runtime, silencing the warning: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation The binding is only needed in the target platform; no Require-Bundle is necessary since SLF4J discovers the binding via classpath scanning.
1 parent 284a3a3 commit ea0f764

File tree

5 files changed

+66
-66
lines changed

5 files changed

+66
-66
lines changed

com.avaloq.tools.ddk.check.ui.test/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Require-Bundle: com.avaloq.tools.ddk.check.ui,
2626
Export-Package: com.avaloq.tools.ddk.check.ui.test,
2727
com.avaloq.tools.ddk.check.ui.test.util,
2828
com.avaloq.tools.ddk.check
29-
Import-Package: org.slf4j, org.apache.log4j,
29+
Import-Package: org.apache.log4j,
3030
org.apache.logging.log4j,
3131
org.hamcrest.core,
3232
org.junit.runner;version="4.5.0",

com.avaloq.tools.ddk.test.ui/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@ Export-Package: com.avaloq.tools.ddk.test.ui,
2828
com.avaloq.tools.ddk.test.ui.swtbot,
2929
com.avaloq.tools.ddk.test.ui.swtbot.condition,
3030
com.avaloq.tools.ddk.test.ui.swtbot.util
31-
Import-Package: org.slf4j, org.apache.logging.log4j,org.apache.log4j
31+
Import-Package: org.apache.logging.log4j,org.apache.log4j
3232
Eclipse-RegisterBuddy: org.eclipse.swtbot.swt.finder
3333
Automatic-Module-Name: com.avaloq.tools.ddk.test.ui

com.avaloq.tools.ddk.xtext.test.core/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Require-Bundle: com.avaloq.tools.ddk.xtext,
2828
org.eclipse.emf.common,
2929
com.avaloq.tools.ddk,
3030
junit-jupiter-api
31-
Import-Package: org.slf4j, org.apache.logging.log4j,org.apache.log4j
31+
Import-Package: org.apache.logging.log4j,org.apache.log4j
3232
Export-Package: com.avaloq.tools.ddk.xtext.test,
3333
com.avaloq.tools.ddk.xtext.test.contentassist,
3434
com.avaloq.tools.ddk.xtext.test.conversion,

com.avaloq.tools.ddk.xtext.test/META-INF/MANIFEST.MF

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ Import-Package: com.avaloq.tools.ddk.check.runtime.test.core,
4646
com.avaloq.tools.ddk.xtext.test.export,
4747
com.avaloq.tools.ddk.xtext.test.format,
4848
com.avaloq.tools.ddk.xtext.ui.test,
49-
org.apache.log4j,
50-
org.slf4j
49+
org.apache.log4j
5150
Export-Package: com.avaloq.tools.ddk.xtext,
5251
com.avaloq.tools.ddk.xtext.formatter,
5352
com.avaloq.tools.ddk.xtext.formatter.services,

ddk-target/ddk.target

Lines changed: 62 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -1,64 +1,65 @@
11
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
22
<?pde version="3.8"?>
33
<target name="DDK Target" sequenceNumber="25">
4-
<locations>
5-
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
6-
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="0.0.0"/>
7-
<unit id="org.eclipse.swtbot.feature.group" version="0.0.0"/>
8-
<unit id="org.eclipse.swtbot.ide.feature.group" version="0.0.0"/>
9-
<unit id="org.eclipse.swtbot.eclipse.test.junit.feature.group" version="0.0.0"/>
10-
<repository location="http://download.eclipse.org/technology/swtbot/releases/4.2.1/"/>
11-
</location>
12-
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
13-
<unit id="org.eclipse.pde.source.feature.group" version="0.0.0"/>
14-
<unit id="org.eclipse.jdt.source.feature.group" version="0.0.0"/>
15-
<unit id="org.eclipse.platform.feature.group" version="0.0.0"/>
16-
<unit id="org.eclipse.platform.source.feature.group" version="0.0.0"/>
17-
<repository location="https://download.eclipse.org/eclipse/updates/4.34/"/>
18-
</location>
19-
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
20-
<unit id="org.eclipse.emf.sdk.feature.group" version="0.0.0"/>
21-
<repository location="https://download.eclipse.org/modeling/emf/emf/builds/release/2.39.0/"/>
22-
</location>
23-
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
24-
<unit id="org.eclipse.uml2.sdk.feature.group" version="0.0.0"/>
25-
<repository location="https://download.eclipse.org/releases/2022-12/202212071000/"/>
26-
</location>
27-
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
28-
<unit id="org.eclipse.xtend" version="0.0.0"/>
29-
<unit id="org.eclipse.xtend.typesystem.emf" version="0.0.0"/>
30-
<unit id="org.eclipse.xtend.util.stdlib" version="0.0.0"/>
31-
<repository location="https://download.eclipse.org/modeling/m2t/xpand/updates/releases/R201605260315/"/>
32-
</location>
33-
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
34-
<unit id="org.eclipse.emf.mwe2.runtime.sdk.feature.group" version="0.0.0"/>
35-
<unit id="org.eclipse.emf.mwe2.launcher.feature.group" version="0.0.0"/>
36-
<repository location="https://download.eclipse.org/modeling/emft/mwe/updates/releases/2.25.0/"/>
37-
</location>
38-
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
39-
<unit id="org.eclipse.xtend.sdk.feature.group" version="0.0.0"/>
40-
<unit id="org.eclipse.xtext.sdk.feature.group" version="0.0.0"/>
41-
<unit id="org.eclipse.xtext.xtext.generator" version="0.0.0"/>
42-
<repository location="https://download.eclipse.org/modeling/tmf/xtext/updates/releases/2.42.0/"/>
43-
</location>
44-
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
45-
<repository location="https://download.eclipse.org/lsp4j/updates/releases/1.0.0/"/>
46-
<unit id="org.eclipse.lsp4j.sdk.feature.group" version="0.0.0"/>
47-
</location>
48-
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
49-
<repository location="https://download.eclipse.org/tools/orbit/downloads/drops/R20230531010532/repository"/>
50-
<unit id="org.apache.logging.log4j" version="2.17.1.v20220106-2156"/>
51-
<unit id="org.apache.commons.lang" version="2.6.0.v20220406-2305"/>
52-
<unit id="org.apache.commons.logging" version="1.2.0.v20180409-1502"/>
53-
<unit id="org.apache.log4j" version="1.2.24.v20221221-2012"/>
54-
<unit id="org.mockito.mockito-core" version="4.8.1.v20221103-2317"/>
55-
<unit id="org.hamcrest" version="2.2.0.v20210711-0821"/>
56-
<unit id="org.junit" version="4.13.2.v20211018-1956"/>
57-
</location>
58-
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
59-
<repository location="https://download.eclipse.org/tools/orbit/simrel/maven-osgi/2025-09"/>
60-
<unit id="junit-jupiter-api" version="5.13.4"/>
61-
<unit id="junit-vintage-engine" version="5.13.4"/>
62-
</location>
63-
</locations>
64-
</target>
4+
<locations>
5+
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
6+
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="0.0.0" />
7+
<unit id="org.eclipse.swtbot.feature.group" version="0.0.0" />
8+
<unit id="org.eclipse.swtbot.ide.feature.group" version="0.0.0" />
9+
<unit id="org.eclipse.swtbot.eclipse.test.junit.feature.group" version="0.0.0" />
10+
<repository location="http://download.eclipse.org/technology/swtbot/releases/4.2.1/" />
11+
</location>
12+
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
13+
<unit id="org.eclipse.pde.source.feature.group" version="0.0.0" />
14+
<unit id="org.eclipse.jdt.source.feature.group" version="0.0.0" />
15+
<unit id="org.eclipse.platform.feature.group" version="0.0.0" />
16+
<unit id="org.eclipse.platform.source.feature.group" version="0.0.0" />
17+
<repository location="https://download.eclipse.org/eclipse/updates/4.34/" />
18+
</location>
19+
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
20+
<unit id="org.eclipse.emf.sdk.feature.group" version="0.0.0" />
21+
<repository location="https://download.eclipse.org/modeling/emf/emf/builds/release/2.39.0/" />
22+
</location>
23+
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
24+
<unit id="org.eclipse.uml2.sdk.feature.group" version="0.0.0" />
25+
<repository location="https://download.eclipse.org/releases/2022-12/202212071000/" />
26+
</location>
27+
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
28+
<unit id="org.eclipse.xtend" version="0.0.0" />
29+
<unit id="org.eclipse.xtend.typesystem.emf" version="0.0.0" />
30+
<unit id="org.eclipse.xtend.util.stdlib" version="0.0.0" />
31+
<repository location="https://download.eclipse.org/modeling/m2t/xpand/updates/releases/R201605260315/" />
32+
</location>
33+
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
34+
<unit id="org.eclipse.emf.mwe2.runtime.sdk.feature.group" version="0.0.0" />
35+
<unit id="org.eclipse.emf.mwe2.launcher.feature.group" version="0.0.0" />
36+
<repository location="https://download.eclipse.org/modeling/emft/mwe/updates/releases/2.25.0/" />
37+
</location>
38+
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
39+
<unit id="org.eclipse.xtend.sdk.feature.group" version="0.0.0" />
40+
<unit id="org.eclipse.xtext.sdk.feature.group" version="0.0.0" />
41+
<unit id="org.eclipse.xtext.xtext.generator" version="0.0.0" />
42+
<repository location="https://download.eclipse.org/modeling/tmf/xtext/updates/releases/2.42.0/" />
43+
</location>
44+
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
45+
<repository location="https://download.eclipse.org/lsp4j/updates/releases/1.0.0/" />
46+
<unit id="org.eclipse.lsp4j.sdk.feature.group" version="0.0.0" />
47+
</location>
48+
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
49+
<repository location="https://download.eclipse.org/tools/orbit/downloads/drops/R20230531010532/repository" />
50+
<unit id="org.apache.logging.log4j" version="2.17.1.v20220106-2156" />
51+
<unit id="org.apache.commons.lang" version="2.6.0.v20220406-2305" />
52+
<unit id="org.apache.commons.logging" version="1.2.0.v20180409-1502" />
53+
<unit id="org.apache.log4j" version="1.2.24.v20221221-2012" />
54+
<unit id="org.slf4j.binding.nop" version="1.7.30.v20221112-0806" />
55+
<unit id="org.mockito.mockito-core" version="4.8.1.v20221103-2317" />
56+
<unit id="org.hamcrest" version="2.2.0.v20210711-0821" />
57+
<unit id="org.junit" version="4.13.2.v20211018-1956" />
58+
</location>
59+
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
60+
<repository location="https://download.eclipse.org/tools/orbit/simrel/maven-osgi/2025-09" />
61+
<unit id="junit-jupiter-api" version="5.13.4" />
62+
<unit id="junit-vintage-engine" version="5.13.4" />
63+
</location>
64+
</locations>
65+
</target>

0 commit comments

Comments
 (0)