Update pmd to 7.12.0

Author: joaodinissf

com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckMarkerHelpExtensionHelper.java

@@ -12,6 +12,7 @@
 
 import java.util.Collections;
 import java.util.List;
+import java.util.Locale;
 import java.util.NoSuchElementException;
 import java.util.Set;
 
@@ -34,7 +35,6 @@
 
 import com.avaloq.tools.ddk.check.check.Check;
 import com.avaloq.tools.ddk.check.check.CheckCatalog;
-import com.avaloq.tools.ddk.check.check.TriggerKind;
 import com.avaloq.tools.ddk.check.check.XIssueExpression;
 import com.avaloq.tools.ddk.check.generator.CheckGeneratorExtensions;
 import com.avaloq.tools.ddk.check.generator.CheckGeneratorNaming;
@@ -56,7 +56,7 @@ public class CheckMarkerHelpExtensionHelper extends AbstractCheckDocumentationEx
   private static final String MARKERHELP_ELEMENT = "markerHelp";
   public static final String CONTEXT_ID_ATTRIBUTE_TAG = "helpContextId";
   public static final String MARKERTYPE_ATTRIBUTE_TAG = "markerType";
-  private static final String CHECKTYPE_PRAEFIX = "org.eclipse.xtext.ui.check";
+  private static final String CHECKTYPE_PREFIX = "org.eclipse.xtext.ui.check";
   private static final String ATTRIBUTE_ELEMENT = "attribute";
   private static final String ATTRIBUTE_NAME_TAG = "name";
   public static final String ATTRIBUTE_VALUE_TAG = "value";
@@ -260,17 +260,7 @@ private boolean isCatalogContextId(final QualifiedName catalog, final URI uri, f
    * @return the check type
    */
   private String getCheckType(final Check check) {
-    TriggerKind trigger = check.getKind();
-    switch (trigger) {
-    case FAST:
-      return CHECKTYPE_PRAEFIX + ".fast";
-    case NORMAL:
-      return CHECKTYPE_PRAEFIX + ".normal";
-    case EXPENSIVE:
-      return CHECKTYPE_PRAEFIX + ".expensive";
-    default:
-      return null;
-    }
+    return CHECKTYPE_PREFIX + '.' + check.getKind().toString().toUpperCase(Locale.ENGLISH);
   }
 
   @Override

com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckImages.java

@@ -82,7 +82,7 @@ public Image forSeverityRange() {
 
   /**
    * Returns an image for a Check according to its severity (error, warning, info, ignore).
-   * 
+   *
    * @param severity
    *          the severity of the check
    * @return an image representing a Check
@@ -96,7 +96,6 @@ public Image forCheck(final SeverityKind severity) {
     case INFO:
       return imageHelper.getImage(INFO_IMAGE);
     default:
-    case IGNORE:
       return imageHelper.getImage(IGNORE_IMAGE);
     }
   }
@@ -108,7 +107,7 @@ public Image forContext() {
 
   /**
    * Return an Image shared by JDT.
-   * 
+   *
    * @param descriptor
    *          an image descriptor (path)
    * @return the corresponding image

com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/labeling/CheckCfgImages.java

@@ -49,7 +49,7 @@ public Image forConfiguredCatalog() {
 
   /**
    * Returns an image for a Configured Check according to its severity (error, warning, info, ignore).
-   * 
+   *
    * @param severity
    *          the severity of the check
    * @return an image representing a Configured Check
@@ -63,7 +63,6 @@ public Image forConfiguredCheck(final SeverityKind severity) {
     case INFO:
       return imageHelper.getImage(INFO_IMAGE);
     default:
-    case IGNORE:
       return imageHelper.getImage(IGNORE_IMAGE);
     }
   }

com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/ITestEntityActionProvider.java

@@ -20,7 +20,7 @@ public interface ITestEntityActionProvider {
 
   /**
    * Returns the {@link TestEntityAction}s of this {@link ITestEntityActionProvider}.
-   * 
+   *
    * @return the {@link TestEntityAction}s, never {@code null}
    */
   List<TestEntityAction> getTestEntityActions();

ddk-configuration/pmd/ruleset.xml

@@ -76,6 +76,7 @@
     <exclude name="DefaultLabelNotLastInSwitch"/>
     <exclude name="ForLoopCanBeForeach"/>
     <exclude name="GuardLogStatement"/><!--TODO-->
+    <exclude name="ImplicitFunctionalInterface"/>
     <exclude name="UnitTestAssertionsShouldIncludeMessage"/>
     <exclude name="UnitTestContainsTooManyAsserts"/><!--New after PMD 5.3 upgrade, limitation to 1 assert not sensible, would need customization, disabled for the time being-->
     <exclude name="UnitTestShouldIncludeAssert"/>

ddk-parent/pom.xml

@@ -53,7 +53,7 @@
     <spotbugs.plugin.version>4.9.2.0</spotbugs.plugin.version>
     <spotbugs.version>4.9.0</spotbugs.version>
     <pmd.plugin.version>3.26.0</pmd.plugin.version>
-    <pmd.version>7.11.0</pmd.version>
+    <pmd.version>7.12.0</pmd.version>
     <tycho.version>4.0.12</tycho.version>
     <xtend.version>2.38.0</xtend.version>
   </properties>