xDFSReplicationGroup - Currently requires DomainName even though README states optional

[solbirn]

Set-TargetResource populates $ExisitingMembers via FQDN ($ExistingMembers = (Get-DfsrMember @Splat -ErrorAction Stop).DnsName), which causes an error when $DomainName parameter is not populated and $Members parameter is not populated via FQDN.

PowerShell DSC resource MSFT_xDFSReplicationGroup  failed to execute Set-TargetResource functionality with error message: The running command
stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: A computer with the specified name
already exists and cannot be added.
    + CategoryInfo          : InvalidOperation: (:) [], CimException
    + FullyQualifiedErrorId : ProviderOperationExecutionFailure
    + PSComputerName        : localhost

I can think of the following options to resolve:

• Update documentation to mention that DomainName is required when FQDN is not supplied in Members.
• Require Members to be populated via FQDN.
• Update Get-FQDNMemberName helper function to append computer's current domain name if not already included in member name instead of returning the computer name.

[PlagueHO]

Thanks @solbirn - great job submitting this! I'll take a look at this over the weekend.

[PlagueHO]

Hi @solbirn - I'll work on this once this PR is merged (should be over the next few days).