Fix atomic IME text replacement by RasulOs · Pull Request #149 · droidrun/mobilerun-portal

RasulOs · 2026-07-20T20:23:27Z

Summary

replace the complete field atomically with one selection plus commitText for clear=true
reject partial, nonzero-offset, or end-unverified extracted windows before full-field replacement
finish active composition before reading the final pre-commit snapshot, then select and replace the field
verify append operations against the exact result predicted from the original text and selection
never recommit or accessibility-replay any operation after commitText accepts it
distinguish thrown commitText outcomes from observed acceptance and skip replay when delivery is unknown
contain readback exceptions inside the editor and report accepted-but-unverifiable only after observed acceptance
preserve one-shot appends when extracted text or composition preparation is unsupported
preserve accepted and input-session-changed clear outcomes so keyboardClear cannot replay them through accessibility
keep verification, pre-commit retries, and fallback bound to the original input session
advance the session generation for every onStartInput, including editor restarts
ignore app-added U+200B/U+FEFF sentinels for ordinary input, while requiring explicitly requested zero-width characters to survive
route clearText() through the same verified replacement path

Reproduction matrix

Path	Before	After
Accepted append with stale or throwing readback	The append could be committed twice or replayed through accessibility	Returns accepted-but-unverifiable after exactly one commit
Thrown `commitText`	An exception was treated as accepted even though delivery was unknown	Returns commit-outcome-unknown; the API reports an error and skips replay
Accepted clear with stale readback	A retry could select the old length and corrupt a longer replacement	Never recommits; returns accepted-but-unverifiable unless the first readback verifies
Accepted clear with unreadable readback	Boolean collapse could trigger accessibility on a newly focused field	Preserves accepted-but-unverifiable and skips fallback
Active composing region	`commitText` could replace only the composing range	Finishes composition before reading, selecting, and replacing the complete field
Unsupported append preparation	Text could be dropped even though `commitText` was supported	Performs one direct commit at the current selection and skips fallback when accepted
Snapshot-less append	Input was rejected before `commitText`	Commits once at the editor's current selection and skips fallback
Focus changes during input	Retry or fallback could modify a newly focused field	Returns an input-session-changed error without retry or fallback
Editor `restartInput`	A replacement connection retained the previous generation	Every start callback invalidates in-flight work, including restarts
Partial or truncated extracted text	`clear=true` could replace only the extracted slice	Rejects before committing unless the snapshot starts at zero, is a full report, and its represented suffix reaches the field end
Requested zero-width text	A dropped requested character could be normalized into false success	Requested U+200B/U+FEFF must be present exactly to verify
Android 16 Settings search	Legacy input could report success without atomic verification	Shared patched editor produced exactly `MRTEST7319`; the dedicated clear endpoint then emptied the field

No search result was selected. Test text was cleared afterward, and the public Mobilerun IME/accessibility configuration was restored.

Tests

PASS: focused ApiHandlerTest and InputConnectionTextEditorTest
PASS: ./gradlew assembleDebug --no-daemon
Full suite: 480/481 passed. The only failure is the unchanged pre-existing SwitchTintResourceTest.trackTintSeparatesCheckedAndUncheckedStates assertion.
PASS on Android 16 emulator-5554 through the mirrored internal debug package at the latest commit: composition-aware atomic replacement and the dedicated clear endpoint were verified from fresh UI hierarchies.
The public debug APK was not installed over the existing public build because Android rejected its lower version code.

Companion PR

Internal Portal #72

github-actions · 2026-07-20T20:26:39Z

🧪 Test Build Ready

APK for PR #149 is available for testing.

Download APK from workflow run

Artifacts expire after 30 days.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b29ba4565c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-07-21T10:11:30Z

🧪 Test Build Ready

APK for PR #149 is available for testing.

Download APK from workflow run

Artifacts expire after 30 days.

RasulOs · 2026-07-21T10:15:03Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8d1d3d10c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-07-21T10:33:00Z

🧪 Test Build Ready

APK for PR #149 is available for testing.

Download APK from workflow run

Artifacts expire after 30 days.

RasulOs · 2026-07-21T10:34:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9e4442c18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-07-21T10:50:55Z

🧪 Test Build Ready

APK for PR #149 is available for testing.

Download APK from workflow run

Artifacts expire after 30 days.

RasulOs · 2026-07-21T10:52:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb3ebd1aba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-07-21T11:04:15Z

🧪 Test Build Ready

APK for PR #149 is available for testing.

Download APK from workflow run

Artifacts expire after 30 days.

RasulOs · 2026-07-21T11:04:27Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b29890c4a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-07-21T11:19:20Z

🧪 Test Build Ready

APK for PR #149 is available for testing.

Download APK from workflow run

Artifacts expire after 30 days.

RasulOs · 2026-07-21T11:19:42Z

@codex review

chatgpt-codex-connector · 2026-07-21T11:22:48Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: ad8f63509d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-07-21T11:33:03Z

🧪 Test Build Ready

APK for PR #149 is available for testing.

Download APK from workflow run

Artifacts expire after 30 days.

RasulOs · 2026-07-21T11:36:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86a719116a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-07-21T11:48:30Z

🧪 Test Build Ready

APK for PR #149 is available for testing.

Download APK from workflow run

Artifacts expire after 30 days.

RasulOs · 2026-07-21T11:48:32Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f8266f26b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

RasulOs · 2026-07-21T12:03:03Z

@codex review

github-actions · 2026-07-21T12:03:16Z

🧪 Test Build Ready

APK for PR #149 is available for testing.

Download APK from workflow run

Artifacts expire after 30 days.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1bd641fb0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

RasulOs · 2026-07-21T13:26:23Z

Physical Android 16 validation completed against head b1bd641fb0fec6cd4af1a9eb30526b040e9f11f5.

Device: Samsung SM-S918B, Android 16/API 36
WhatsApp: com.whatsapp 2.26.27.85
Debug APK SHA-256: a79fd1dcbb86d4004c49b251be00a39abef78b5e8490813645a15ab783e53a12

Scenario	Result
Settings atomic replacement	PASS: `OLD7319` -> exactly `MRTEST7319`; response: `input done via IME (clear=true)`
Settings append	PASS: `MRTEST` + `7319` -> exactly `MRTEST7319`; response: `input done via IME (clear=false)`
Settings clear	PASS: field returned to hint-only `Search`; response: `Text cleared via IME`
IME restart/reacquisition	PASS: switched Portal -> Samsung -> Portal, then replaced with exactly `MRRESTART7319`
WhatsApp global search	PASS: 3 consecutive replacements with `9911656022`; each response reported IME success; raw text was `U+200B` + requested digits and normalized exactly
WhatsApp contact search	PASS: 2 consecutive replacements with exactly `9911656022`; each response reported IME success
WhatsApp Message yourself composer	PASS: exactly `MRTEST7319`, then cleared via IME; no message sent

No accessibility fallback, false success, false negative, stale suffix, or duplicate append was observed. All test text was cleared. The phone was restored to Samsung Keyboard with accessibility disabled; both debug Portal apps remain installed but inactive.

RasulOs · 2026-07-21T14:33:39Z

Android 16 emulator edge-case validation completed against source head b1bd641fb0fec6cd4af1a9eb30526b040e9f11f5 on emulator-5554 (API 36).

Result: 140/140 runtime cases passed.

Covered:

shorter, longer, and empty atomic replacements;
empty and normal appends;
cursor insertion (ABCDE -> ABCXDE);
selected-range replacement (ABCDE, select CD, insert XY -> ABXYE);
spaces, punctuation, emoji, combining characters, Arabic, requested U+200B/U+FEFF, multiline text, and an exact 4096-character value;
50 alternating replacements, 50 sequential appends, and 20 repeated clears;
no-focused-editor rejection;
inactive-IME accessibility fallback reporting;
numeric Google Messages recipient input and unsent multiline composer input;
focus-change race: 1 induced session change, 0 wrong-field writes;
IME-restart sweep at 0–90 ms: 8 session-change errors with fallback skipped, 2 completed successes, exact BASEX in all 10 outcomes, and 0 duplicate appends.

Repository checks:

Focused input/API unit tests and assembleDebug pass.
The complete testDebugUnitTest run still has only the pre-existing unrelated SwitchTintResourceTest.trackTintSeparatesCheckedAndUncheckedStates tint-resource failure.

No public Portal defect was found and no code change was needed. Test text was cleared, no message was sent, and no draft remains.

fix: replace IME text atomically

b29ba45

RasulOs mentioned this pull request Jul 20, 2026

Verify text input before reporting success droidrun/mobilerun#387

Closed

chatgpt-codex-connector Bot reviewed Jul 20, 2026

View reviewed changes

fix: address IME verification review

c8d1d3d

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread app/src/main/java/com/mobilerun/portal/input/InputConnectionTextEditor.kt

Comment thread app/src/main/java/com/mobilerun/portal/input/InputConnectionTextEditor.kt Outdated

fix: keep IME retries in input session

a9e4442

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread app/src/main/java/com/mobilerun/portal/input/MobilerunKeyboardIME.kt Outdated

fix: preserve IME verification outcomes

eb3ebd1

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread app/src/main/java/com/mobilerun/portal/input/InputConnectionTextEditor.kt

fix: preserve atomic replacement outcomes

b29890c

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread app/src/main/java/com/mobilerun/portal/input/InputConnectionTextEditor.kt Outdated

fix: prevent accepted text input replay

ad8f635

fix: distinguish unknown IME commit outcomes

86a7191

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread app/src/main/java/com/mobilerun/portal/input/MobilerunKeyboardIME.kt Outdated

fix: renew IME sessions on restart

4f8266f

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread app/src/main/java/com/mobilerun/portal/input/InputConnectionTextEditor.kt Outdated

fix: confirm complete extracted fields

b1bd641

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread app/src/main/java/com/mobilerun/portal/input/InputConnectionTextEditor.kt

RasulOs merged commit a511a6b into main Jul 21, 2026
11 of 12 checks passed

Uh oh!

Conversation

RasulOs commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Reproduction matrix

Tests

Companion PR

Uh oh!

github-actions Bot commented Jul 20, 2026

🧪 Test Build Ready

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

🧪 Test Build Ready

Uh oh!

RasulOs commented Jul 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

🧪 Test Build Ready

Uh oh!

RasulOs commented Jul 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

🧪 Test Build Ready

Uh oh!

RasulOs commented Jul 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

🧪 Test Build Ready

Uh oh!

RasulOs commented Jul 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

🧪 Test Build Ready

Uh oh!

RasulOs commented Jul 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

🧪 Test Build Ready

Uh oh!

RasulOs commented Jul 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

🧪 Test Build Ready

RasulOs commented Jul 20, 2026 •

edited

Loading