Duplicate emails sent

[redkrupp]

Hey,

A lightswitch field was added to the user profile to control permissions for sending emails.

I then query all user IDs that have opted out and use the skipMessage tag in the corresponding template.

`
{# get users with switched off notifications #}
{% set userQuery = craft.users()
.notifyNewPositions(0)
.limit(null)
%}

{# get ids of them #}
{% set users = userQuery.all() %}
{% set recipientIds %}
{% for user in users %}
{{ user.id }}{% if not loop.last %}, {% endif %}
{% endfor %}
{% endset %}

{# skip message if notifications are off #}
{% if recipient.user.id in recipientIds %}
{% skipMessage "User is not an intended recipient." %}
{% endif %}
`

So far, so good, the query does retrieve the correct IDs, but I’m still seeing duplicate emails.

Unfortunately, it seems like the skipMessage concept is being ignored.

Any advice?

[redkrupp]

It seems that userIds aren't passed to the recipient.user.id conditional. I tried to hardcode desired ids and it does work as expected.

`{% set recipientIds = [15352, 303] %}

{# skip message if notifications are off #}
{% if recipient.user.id not in recipientIds %}
{% skipMessage "User is not an intended recipient." %}
{% endif %}`

what would be the correct snippet to get all the userIds that have lightswitch set to 1 aka enabled notifications please.

[redkrupp]

This one should work:

`{# get users with switched off notifications #}
{% set recipientIds = craft.users()
.limit(null)
.notifyNewPositions(0)
.status('active')
.ids()
%}

{# skip message if notifications are off #}
{% if recipient.user.id in recipientIds %}
{% skipMessage "User is not an intended recipient." %}
{% endif %}`

[lindseydiloreto]

Are you saying that your last snippet solved the problem? Or are you still experiencing some version of this issue?

[redkrupp]

Yes, the latest snippet does the trick. Any optimization suggestions are welcomed. Thanks.

[lindseydiloreto]

I know this is an old ticket, just tidying up... Glad you got this sorted out!

Looks like your original snippet was sending extra notifications because it was identifying IDs within a comma-separated string, as opposed to an array of IDs.

You were right to use .ids() in your final solution, that was the correct approach. 👍

The cleanest version would probably look like this:

{# Get users with switched off notifications #}
{% set recipientIds = craft.users()
    .notifyNewPositions(0)
    .ids()
%}

{# Skip message if notifications are off #}
{% if recipient.user.id in recipientIds %}
    {% skipMessage "User is not an intended recipient." %}
{% endif %}

No need for .limit(null) or .status('active'), because those are the default values of both.