Skip to content

Commit 6a21ba6

Browse files
committed
Address review comments
1 parent a868959 commit 6a21ba6

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

src/EFCore.SqlServer/Query/Internal/SqlServerSqlTranslatingExpressionVisitor.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -271,9 +271,9 @@ protected override Expression VisitMethodCall(MethodCallExpression methodCallExp
271271
"JSON_PATH_EXISTS",
272272
[translatedJson, translatedPath],
273273
nullable: true,
274-
// Note that json_type() does propagate nullability; however, our query pipeline assumes that if arguments
275-
// propagate nullability, that's the *only* reason for the function to return null; this means that if the
276-
// arguments are non-nullable, the IS NOT NULL wrapping check can be optimized away.
274+
// Note that JSON_PATH_EXISTS() does propagate nullability; however, our query pipeline assumes that if
275+
// arguments propagate nullability, that's the *only* reason for the function to return null; this means that
276+
// if the arguments are non-nullable, the IS NOT NULL wrapping check can be optimized away.
277277
argumentsPropagateNullability: [false, false],
278278
typeof(int)),
279279
_sqlExpressionFactory.Constant(1));

test/EFCore.Relational.Specification.Tests/Query/Translations/JsonTranslationsRelationalTestBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ namespace Microsoft.EntityFrameworkCore.Query.Translations;
88

99
// This test suite covers translations of JSON functions on EF.Functions (e.g. EF.Functions.JsonExists).
1010
// It does not cover general, built-in JSON support via complex type mapping, etc.
11-
public abstract class JsonTranslationsRelatinalTestBase<TFixture>(TFixture fixture) : QueryTestBase<TFixture>(fixture)
12-
where TFixture : JsonTranslationsRelatinalTestBase<TFixture>.JsonTranslationsQueryFixtureBase, new()
11+
public abstract class JsonTranslationsRelationalTestBase<TFixture>(TFixture fixture) : QueryTestBase<TFixture>(fixture)
12+
where TFixture : JsonTranslationsRelationalTestBase<TFixture>.JsonTranslationsQueryFixtureBase, new()
1313
{
1414
[ConditionalFact]
1515
public virtual Task JsonExists_on_scalar_string_column()

test/EFCore.SqlServer.FunctionalTests/Query/Translations/JsonTranslationsSqlServerTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
namespace Microsoft.EntityFrameworkCore.Query.Translations;
55

6-
public class JsonTranslationsSqlServerTest : JsonTranslationsRelatinalTestBase<JsonTranslationsSqlServerTest.JsonTranslationsQuerySqlServerFixture>
6+
public class JsonTranslationsSqlServerTest : JsonTranslationsRelationalTestBase<JsonTranslationsSqlServerTest.JsonTranslationsQuerySqlServerFixture>
77
{
88
public JsonTranslationsSqlServerTest(JsonTranslationsQuerySqlServerFixture fixture, ITestOutputHelper testOutputHelper)
99
: base(fixture)

test/EFCore.Sqlite.FunctionalTests/Query/Translations/JsonTranslationsSqliteTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
namespace Microsoft.EntityFrameworkCore.Query.Translations;
55

6-
public class JsonTranslationsSqliteTest : JsonTranslationsRelatinalTestBase<JsonTranslationsSqliteTest.JsonTranslationsQuerySqliteFixture>
6+
public class JsonTranslationsSqliteTest : JsonTranslationsRelationalTestBase<JsonTranslationsSqliteTest.JsonTranslationsQuerySqliteFixture>
77
{
88
public JsonTranslationsSqliteTest(JsonTranslationsQuerySqliteFixture fixture, ITestOutputHelper testOutputHelper)
99
: base(fixture)

0 commit comments

Comments
 (0)