Migrate pre-commit hook from nvm/sdkman to mise for consistent tool version management

[spbolton]

Description

Replace nvm and sdkman with mise in the pre-commit hook to provide consistent Node.js, Java, and Yarn version management across all developer machines. This eliminates the need for developers to install and maintain nvm and sdkman separately, and resolves ENOBUFS resource exhaustion issues caused by the Nx daemon in Git hook subprocess contexts.

Acceptance Criteria

• [Define what needs to be accomplished]

Additional Notes

[Any additional context or notes]

[spbolton]

Implementation Summary

Changes Made

1. Removed nvm and sdkman dependencies:

• Deleted setup_nvm() function
• Deleted check_sdkman() function
• Removed ~100+ lines of complex retry logic for ENOBUFS handling

2. Configured mise for tool version management:

• Updated .mise.toml with required settings:
  • legacy_version_file = true - Enables reading .nvmrc and .sdkmanrc
  • idiomatic_version_file_enable_tools = ["java", "node"] - Required for Java/Node version file detection
• Configured auto_install = true for automatic tool installation

3. Updated pre-commit hook:

• All yarn/node/java commands now use mise exec --
• Added upfront version display showing Java implementation (microsoft-21.0.8), Node (22.15.0), and Yarn (1.22.22)
• Fixed process substitution syntax error (replaced with temp files for shell compatibility)
• Set NX_DAEMON=false to prevent resource exhaustion in Git hook subprocess context

Key Fixes

ENOBUFS Root Cause Resolution:

• Problem: Nx daemon spawns 9+ worker processes, combined with Git hook subprocess limits caused ENOBUFS
• Solution: Disable Nx daemon in Git hooks with NX_DAEMON=false (following Nx's CI pattern)
• Result: No more resource exhaustion, hooks run reliably
• Note: --parallel=1 was initially added but found to be unnecessary; NX_DAEMON=false alone is sufficient

Git Hooks Path Fix:

• Fixed core.hooksPath to point to core-web/.husky (correct location in worktree)
• Hook path can be reset during git operations like rebase/squash

Benefits

1. Unified Tool Management: Single tool (mise) replaces nvm + sdkman
2. Automatic Version Detection: Reads .nvmrc and .sdkmanrc automatically
3. Consistent Across Developers: No manual tool installation or configuration
4. Simplified Script: Net -62 lines of code removed
5. Reliable Execution: ENOBUFS issue completely resolved
6. Better Performance: Removed complex retry logic, faster hook execution

Developer Requirements

New requirement: Developers must install and activate mise

# Install mise
brew install mise  # or: curl https://mise.run | sh

# Activate in shell (~/.zshrc or ~/.bashrc)
eval "$(mise activate zsh)"  # for zsh
eval "$(mise activate bash)" # for bash

# Reload shell
source ~/.zshrc

No longer needed: nvm, sdkman (mise handles both)

Testing

All commits succeeded with mise-managed tools:

• ✅ Lint and format ran successfully
• ✅ Maven validation completed
• ✅ 8 TypeScript files formatted and staged
• ✅ No ENOBUFS errors

Documentation Needed

• Update developer setup documentation to include mise installation
• Add mise troubleshooting section
• Document migration path from nvm/sdkman to mise
• Update CI/CD documentation if applicable

References

• Nx Daemon documentation: https://nx.dev/docs/concepts/nx-daemon
• Mise documentation: https://mise.jdx.dev/
• Related issue: affected commands do not work in git pre-commit hook nrwl/nx#733 (Nx affected in git hooks)

[spbolton]

This issue is being addressed in PR #34219

[github-actions]

PRs linked to this issue

• build(ci): Migrate precommit hook from nvmsdkman to mise for (#34214) by @spbolton

[wezell]

Is a step missing? Tried mise locally in core and got:

➜  core git:(main) ✗ eval "$(mise activate zsh)"  # for zsh
mise ERROR error parsing config file: ~/git/dotcms/core/.mise.toml
mise ERROR Config files in ~/git/dotcms/core/.mise.toml are not trusted.
Trust them with `mise trust`. See https://mise.jdx.dev/cli/trust.html for more information.
mise ERROR Run with --verbose or MISE_VERBOSE=1 for more information
mise ERROR error parsing config file: ~/git/dotcms/core/.mise.toml
mise ERROR Config files in ~/git/dotcms/core/.mise.toml are not trusted.
Trust them with `mise trust`. See https://mise.jdx.dev/cli/trust.html for more information.
mise ERROR Run with --verbose or MISE_VERBOSE=1 for more information