better check direction param

Author: guillaume-kotulski

src/checker.ts

@@ -45,6 +45,14 @@ interface TypeMismatch {
     paramsType: string[];
 }
 
+/**
+ * Parameter information with direction
+ */
+interface ParameterInfo {
+    name: string;
+    direction: Direction;
+}
+
 /**
  * Validation result for variant parameters
  */
@@ -102,19 +110,36 @@ export class SyntaxChecker {
     }
 
     /**
-     * Extract actual parameter names from parameter array
+     * Extract actual parameter names and directions from parameter array
+     * @param params - Parameter array from documentation
+     * @returns Array of parameter info with names and directions
+     */
+    extractActualParamNames(params: DocumentationParameter[]): ParameterInfo[] {
+        if (!params || params.length === 0) return [];
+
+        return params
+            .filter(param => param.direction !== undefined) // Only include params with valid direction
+            .map(param => ({
+                name: param.name.toLowerCase(),
+                direction: param.direction!
+            }));
+    }
+
+    /**
+     * Get input parameter names (excluding return parameters)
      * @param params - Parameter array from documentation
-     * @returns Array of parameter names
+     * @returns Array of input parameter names
      */
-    extractActualParamNames(params: DocumentationParameter[]): string[] {
+    getInputParameterNames(params: DocumentationParameter[]): string[] {
         if (!params || params.length === 0) return [];
 
         return params
             .filter(param => {
                 const name = param.name;
                 const direction = param.direction;
-                // Only include input and input/output parameters, exclude return parameters
+                // Only include parameters with valid direction, and exclude return parameters
                 return (
+                    direction !== undefined &&
                     direction !== Direction.Return &&
                     name !== 'Function result'
                 );
@@ -402,7 +427,8 @@ export class SyntaxChecker {
 
         // Check if there are any errors/warnings
         let hasErrors = false;
-        const actualParamNames = params && params.length > 0 ? this.extractActualParamNames(params) : [];
+        const actualParamNames = params && params.length > 0 ? this.getInputParameterNames(params) : [];
+        const allParamInfo = params && params.length > 0 ? this.extractActualParamNames(params) : [];
 
         // Check each parsed variant for issues (malformations and parameter errors)
         parsedParams.forEach((variant) => {
@@ -421,6 +447,7 @@ export class SyntaxChecker {
                 console.log('\nActual Params:', JSON.stringify(params, null, 2));
 
                 console.log('Expected parameter names:', actualParamNames);
+                console.log('All parameter info:', allParamInfo.map(p => `${p.name} (direction: ${p.direction})`));
 
                 // Check each parsed variant
                 parsedParams.forEach((variant, index) => {
@@ -456,6 +483,7 @@ export class SyntaxChecker {
             case '->': return Direction.In;
             case '←':
             case '<-': return Direction.Return;
+            case '&#8596;':
             case '<->': return Direction.IO;
         }
         return undefined;

tests/integration/entry-points.test.ts

@@ -69,7 +69,7 @@ describe('Entry Points and CLI', () => {
             const checker = new SyntaxChecker();
 
             // Test basic functionality
-            const result = checker.extractActualParamNames(checker.parseParams([
+            const result = checker.getInputParameterNames(checker.parseParams([
                 ['param1', 'Type1', '→', 'Description1']
             ] as any));
 
@@ -151,7 +151,7 @@ describe('Entry Points and CLI', () => {
 
             const promises = Array.from({ length: 10 }, async (_, i) => {
                 const checker = new module.SyntaxChecker();
-                return checker.extractActualParamNames(checker.parseParams([
+                return checker.getInputParameterNames(checker.parseParams([
                     [`param${i}`, `Type${i}`, '→', `Description${i}`]
                 ] as any));
             });

tests/validation/checker-comprehensive.test.ts

@@ -28,7 +28,7 @@ describe('SyntaxChecker - Comprehensive Coverage', () => {
                 ['Result', 'Type3', '<-', 'Description3']
             ];
 
-            const result = checker.extractActualParamNames(checker.parseParams(params));
+            const result = checker.getInputParameterNames(checker.parseParams(params));
 
             expect(result).toEqual(['param1', 'param2']);
         });
@@ -40,7 +40,7 @@ describe('SyntaxChecker - Comprehensive Coverage', () => {
                 ['Result', 'Type3', '<-', 'Description3']
             ];
 
-            const result = checker.extractActualParamNames(checker.parseParams(params));
+            const result = checker.getInputParameterNames(checker.parseParams(params));
 
             expect(result).toEqual(['param1', 'param2']);
         });
@@ -61,7 +61,7 @@ describe('SyntaxChecker - Comprehensive Coverage', () => {
                 ['UPPERPARAM', 'Type2', '->', 'Description2']
             ];
 
-            const result = checker.extractActualParamNames(checker.parseParams(params));
+            const result = checker.getInputParameterNames(checker.parseParams(params));
 
             expect(result).toEqual(['paramname', 'upperparam']);
         });

tests/validation/command-validation.test.ts

@@ -73,7 +73,7 @@ describe('SyntaxChecker Command Validation', () => {
                 ['param4', 'Object', '↔', 'Input/Output parameter (HTML arrow)']
             ] as any[];
 
-            const actualParamNames = checker.extractActualParamNames(checker.parseParams(params));
+            const actualParamNames = checker.getInputParameterNames(checker.parseParams(params));
             expect(actualParamNames).toContain('param1');
             expect(actualParamNames).toContain('param2');
             expect(actualParamNames).toContain('param3');
@@ -87,7 +87,7 @@ describe('SyntaxChecker Command Validation', () => {
                 ['error', 'Boolean', '<-', 'Output parameter (HTML arrow)']
             ] as any[];
 
-            const actualParamNames = checker.extractActualParamNames(checker.parseParams(params));
+            const actualParamNames = checker.getInputParameterNames(checker.parseParams(params));
             expect(actualParamNames).toContain('param1');
             expect(actualParamNames).not.toContain('result'); // Result should be excluded
             expect(actualParamNames).not.toContain('error');