switch performance tier of nfs share (#1805)

* deprecate region from nfs apis

* add switch performance tier

* godo version update

Author: v-amanjain-afk

commands/nfs.go

@@ -42,9 +42,10 @@ func Nfs() *Command {
 	AddStringFlag(cmdNfsCreate, "region", "r", "", "the region where the NFS share resides", requiredOpt())
 	AddStringFlag(cmdNfsCreate, "size", "s", "", "the size of the NFS share in GiB", requiredOpt())
 	AddStringSliceFlag(cmdNfsCreate, "vpc-ids", "", nil, "the list of VPC IDs that should be able to access the share", requiredOpt())
+	AddStringFlag(cmdNfsCreate, "performance-tier", "", "", "the performance tier of the NFS share", requiredOpt())
 	cmdNfsCreate.Example =
-		`doctl nfs create --name sammy-nfs-share --region 'atl1' --size 50 --vpc-ids 74922c16-5466-42a5-ac58-0e8069918b6b
-doctl nfs create --name my-nfs-share --region 'nyc2' --size 100 --vpc-ids 74922c16-5466-42a5-ac58-0e8069918b6b`
+		`doctl nfs create --name sammy-nfs-share --region 'atl1' --size 50 --vpc-ids 74922c16-5466-42a5-ac58-0e8069918b6b --performance-tier standard
+doctl nfs create --name my-nfs-share --region 'nyc2' --size 100 --vpc-ids 74922c16-5466-42a5-ac58-0e8069918b6b --performance-tier standard`
 
 	cmdNfsGet := CmdBuilder(cmd, nfsGet, "get [flags]", "Get an NFS share by ID", "Get an NFS share with the given ID and region.", Writer, displayerType(&displayers.Nfs{}))
 	AddStringFlag(cmdNfsGet, "id", "", "", "the ID of the NFS share", requiredOpt())
@@ -89,6 +90,13 @@ doctl nfs list --region 'atl1' --format ID,Name,Size,Status`
 	cmdNfsDetach.Example =
 		`doctl nfs detach --region 'atl1' --id b050990d-4337-4a9d-9c8d-9f759a83936a --vpc_id example-vpc-id`
 
+	cmdNfsSwitchPerformanceTier := CmdBuilder(cmd, nfsSwitchPerformanceTier, "switch-performance-tier [flags]", "Switch the performance tier of an NFS share", "Switch the performance tier of an NFS share with the given ID and tier.", Writer)
+	AddStringFlag(cmdNfsSwitchPerformanceTier, "id", "", "", "the ID of the NFS share", requiredOpt())
+	AddStringFlag(cmdNfsSwitchPerformanceTier, "performance-tier", "", "", "the performance tier of the NFS share", requiredOpt())
+	AddBoolFlag(cmdNfsSwitchPerformanceTier, doctl.ArgCommandWait, "", false, "Wait for action to complete")
+	cmdNfsSwitchPerformanceTier.Example =
+		`doctl nfs switch-performance-tier --id b050990d-4337-4a9d-9c8d-9f759a83936a --performance-tier high`
+
 	cmd.AddCommand(nfsSnapshots())
 
 	return cmd
@@ -160,11 +168,13 @@ func nfsCreate(c *CmdConfig) error {
 		return err
 	}
 
+	performanceTier, _ := c.Doit.GetString(c.NS, "performance-tier")
 	r := &godo.NfsCreateRequest{
-		Name:    name,
-		Region:  region,
-		SizeGib: size,
-		VpcIDs:  vpcIDs,
+		Name:            name,
+		Region:          region,
+		SizeGib:         size,
+		VpcIDs:          vpcIDs,
+		PerformanceTier: performanceTier,
 	}
 
 	share, err := c.Nfs().Create(r)
@@ -400,6 +410,38 @@ func nfsDetach(c *CmdConfig) error {
 	return c.Display(item)
 }
 
+func nfsSwitchPerformanceTier(c *CmdConfig) error {
+	id, err := c.Doit.GetString(c.NS, "id")
+	if err != nil {
+		return err
+	}
+
+	performanceTier, err := c.Doit.GetString(c.NS, "performance-tier")
+	if err != nil {
+		return err
+	}
+
+	action, err := c.NfsActions().SwitchPerformanceTier(id, performanceTier)
+	if err != nil {
+		return err
+	}
+
+	wait, err := c.Doit.GetBool(c.NS, doctl.ArgCommandWait)
+	if err != nil {
+		return err
+	}
+
+	if wait {
+		_, err := actionWait(c, action.ID, 5)
+		if err != nil {
+			return err
+		}
+	}
+
+	item := &displayers.NfsAction{NfsActions: []do.NfsAction{*action}}
+	return c.Display(item)
+}
+
 func displayNfs(c *CmdConfig, shares ...do.Nfs) error {
 	item := &displayers.Nfs{NfsShares: shares}
 	return c.Display(item)

commands/nfs_test.go

@@ -59,7 +59,7 @@ var (
 func TestNfsCommand(t *testing.T) {
 	cmd := Nfs()
 	assert.NotNil(t, cmd)
-	assertCommandNames(t, cmd, "create", "list", "get", "delete", "snapshot", "resize", "attach", "detach")
+	assertCommandNames(t, cmd, "create", "list", "get", "delete", "snapshot", "resize", "attach", "detach", "switch-performance-tier")
 }
 
 func TestRunNfsCreate(t *testing.T) {
@@ -80,10 +80,11 @@ func TestRunNfsCreate(t *testing.T) {
 			withTestClient(t, func(config *CmdConfig, tm *tcMocks) {
 				if !tc.expectErr {
 					req := &godo.NfsCreateRequest{
-						Name:    "sammy-share",
-						Region:  "atl1",
-						SizeGib: 1024,
-						VpcIDs:  []string{"a0ca4d02-1c86-4330-a4ff-310ee60c7de0"},
+						Name:            "sammy-share",
+						Region:          "atl1",
+						SizeGib:         1024,
+						VpcIDs:          []string{"a0ca4d02-1c86-4330-a4ff-310ee60c7de0"},
+						PerformanceTier: "standard",
 					}
 					tm.nfs.EXPECT().Create(req).Return(&testNfs, nil)
 				}
@@ -92,7 +93,7 @@ func TestRunNfsCreate(t *testing.T) {
 				config.Doit.Set(config.NS, "region", tc.args[1])
 				config.Doit.Set(config.NS, "size", tc.args[2])
 				config.Doit.Set(config.NS, "vpc-ids", []string{tc.args[3]})
-
+				config.Doit.Set(config.NS, "performance-tier", "standard")
 				err := nfsCreate(config)
 				if tc.expectErr {
 					require.Error(t, err)
@@ -493,3 +494,52 @@ func TestRunNfsDetach(t *testing.T) {
 		})
 	}
 }
+
+func TestRunNfsSwitchPerformanceTier(t *testing.T) {
+	testCases := []struct {
+		name            string
+		id              string
+		performanceTier string
+		wait            bool
+		expectErr       bool
+	}{
+		{
+			name:            "success without wait",
+			id:              testId,
+			performanceTier: "standard",
+			wait:            false,
+			expectErr:       false,
+		},
+		{
+			name:            "success with wait",
+			id:              testId,
+			performanceTier: "premium",
+			wait:            true,
+			expectErr:       false,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			withTestClient(t, func(config *CmdConfig, tm *tcMocks) {
+				if !tc.expectErr {
+					tm.nfsActions.EXPECT().SwitchPerformanceTier(tc.id, tc.performanceTier).Return(&testNfsAction, nil)
+					if tc.wait {
+						tm.actions.EXPECT().Get(testNfsAction.ID).Return(&testAction, nil)
+					}
+				}
+
+				config.Doit.Set(config.NS, "id", tc.id)
+				config.Doit.Set(config.NS, "performance-tier", tc.performanceTier)
+				config.Doit.Set(config.NS, "wait", tc.wait)
+
+				err := nfsSwitchPerformanceTier(config)
+				if tc.expectErr {
+					require.Error(t, err)
+				} else {
+					require.NoError(t, err)
+				}
+			})
+		})
+	}
+}

do/mocks/AppsService.go

@@ -33,6 +33,7 @@ type NfsActionsService interface {
 	Snapshot(id, name, region string) (*NfsAction, error)
 	Attach(id, vpcID, region string) (*NfsAction, error)
 	Detach(id, vpcID, region string) (*NfsAction, error)
+	SwitchPerformanceTier(id, tier string) (*NfsAction, error)
 }
 
 type nfsActionsService struct {
@@ -79,3 +80,11 @@ func (s *nfsActionsService) Detach(id, vpcID, region string) (*NfsAction, error)
 	}
 	return &NfsAction{NfsAction: action}, nil
 }
+
+func (s *nfsActionsService) SwitchPerformanceTier(id, tier string) (*NfsAction, error) {
+	action, _, err := s.client.NfsActions.SwitchPerformanceTier(context.TODO(), id, tier)
+	if err != nil {
+		return nil, err
+	}
+	return &NfsAction{NfsAction: action}, nil
+}

do/mocks/NfsActionsService.go

@@ -5,7 +5,7 @@ go 1.24
 require (
 	github.com/blang/semver v3.5.1+incompatible
 	github.com/creack/pty v1.1.21
-	github.com/digitalocean/godo v1.174.0
+	github.com/digitalocean/godo v1.175.0
 	github.com/docker/cli v24.0.5+incompatible
 	github.com/docker/docker v25.0.6+incompatible
 	github.com/docker/docker-credential-helpers v0.7.0 // indirect

do/nfs_actions.go

@@ -91,8 +91,8 @@ github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSs
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/digitalocean/godo v1.174.0 h1:9nVX8WqAPd7ZN9Yn63HeLRAI8m2vi9QeotcDvYmB+ns=
-github.com/digitalocean/godo v1.174.0/go.mod h1:xQsWpVCCbkDrWisHA72hPzPlnC+4W5w/McZY5ij9uvU=
+github.com/digitalocean/godo v1.175.0 h1:tpfwJFkBzpePxvvFazOn69TXctdxuFlOs7DMVXsI7oU=
+github.com/digitalocean/godo v1.175.0/go.mod h1:xQsWpVCCbkDrWisHA72hPzPlnC+4W5w/McZY5ij9uvU=
 github.com/distribution/reference v0.6.0 h1:0IXCQ5g4/QMHHkarYzh5l+u8T3t73zM5QvfrDyIgxBk=
 github.com/distribution/reference v0.6.0/go.mod h1:BbU0aIcezP1/5jX/8MP0YiH4SdvB5Y4f/wlDRiLyi3E=
 github.com/docker/cli v24.0.5+incompatible h1:WeBimjvS0eKdH4Ygx+ihVq1Q++xg36M/rMi4aXAvodc=