deprecate region from nfs apis (#1800)

Author: v-amanjain-afk

commands/nfs.go

@@ -180,12 +180,7 @@ func nfsGet(c *CmdConfig) error {
 	if err != nil {
 		return err
 	}
-
-	region, err := c.Doit.GetString(c.NS, "region")
-	if err != nil {
-		return err
-	}
-
+	region, _ := c.Doit.GetString(c.NS, "region")
 	share, err := c.Nfs().Get(id, region)
 	if err != nil {
 		return err
@@ -195,11 +190,7 @@ func nfsGet(c *CmdConfig) error {
 }
 
 func nfsList(c *CmdConfig) error {
-	region, err := c.Doit.GetString(c.NS, "region")
-	if err != nil {
-		return err
-	}
-
+	region, _ := c.Doit.GetString(c.NS, "region")
 	shares, err := c.Nfs().List(region)
 	if err != nil {
 		return err
@@ -214,10 +205,7 @@ func nfsDelete(c *CmdConfig) error {
 		return err
 	}
 
-	region, err := c.Doit.GetString(c.NS, "region")
-	if err != nil {
-		return err
-	}
+	region, _ := c.Doit.GetString(c.NS, "region")
 
 	err = c.Nfs().Delete(id, region)
 	if err != nil {
@@ -238,10 +226,7 @@ func nfsSnapshotCreate(c *CmdConfig) error {
 		return err
 	}
 
-	region, err := c.Doit.GetString(c.NS, "region")
-	if err != nil {
-		return err
-	}
+	region, _ := c.Doit.GetString(c.NS, "region")
 
 	action, err := c.NfsActions().Snapshot(shareID, name, region)
 	if err != nil {
@@ -265,10 +250,7 @@ func nfsSnapshotCreate(c *CmdConfig) error {
 }
 
 func nfsSnapshotList(c *CmdConfig) error {
-	region, err := c.Doit.GetString(c.NS, "region")
-	if err != nil {
-		return err
-	}
+	region, _ := c.Doit.GetString(c.NS, "region")
 
 	shareId, _ := c.Doit.GetString(c.NS, "share-id")
 
@@ -286,10 +268,7 @@ func nfsSnapshotGet(c *CmdConfig) error {
 		return err
 	}
 
-	region, err := c.Doit.GetString(c.NS, "region")
-	if err != nil {
-		return err
-	}
+	region, _ := c.Doit.GetString(c.NS, "region")
 
 	snapshot, err := c.Nfs().GetSnapshot(id, region)
 	if err != nil {
@@ -305,10 +284,7 @@ func nfsSnapshotDelete(c *CmdConfig) error {
 		return err
 	}
 
-	region, err := c.Doit.GetString(c.NS, "region")
-	if err != nil {
-		return err
-	}
+	region, _ := c.Doit.GetString(c.NS, "region")
 
 	err = c.Nfs().DeleteSnapshot(id, region)
 	if err != nil {
@@ -324,10 +300,7 @@ func nfsResize(c *CmdConfig) error {
 		return err
 	}
 
-	region, err := c.Doit.GetString(c.NS, "region")
-	if err != nil {
-		return err
-	}
+	region, _ := c.Doit.GetString(c.NS, "region")
 
 	sizeStr, err := c.Doit.GetString(c.NS, "size")
 	if err != nil {
@@ -366,10 +339,7 @@ func nfsAttach(c *CmdConfig) error {
 		return err
 	}
 
-	region, err := c.Doit.GetString(c.NS, "region")
-	if err != nil {
-		return err
-	}
+	region, _ := c.Doit.GetString(c.NS, "region")
 
 	vpcIdStr, err := c.Doit.GetString(c.NS, "vpc_id")
 	if err != nil {
@@ -403,11 +373,7 @@ func nfsDetach(c *CmdConfig) error {
 		return err
 	}
 
-	region, err := c.Doit.GetString(c.NS, "region")
-	if err != nil {
-		return err
-	}
-
+	region, _ := c.Doit.GetString(c.NS, "region")
 	vpcIdStr, err := c.Doit.GetString(c.NS, "vpc_id")
 	if err != nil {
 		return err

go.mod

@@ -5,7 +5,7 @@ go 1.24
 require (
 	github.com/blang/semver v3.5.1+incompatible
 	github.com/creack/pty v1.1.21
-	github.com/digitalocean/godo v1.172.0
+	github.com/digitalocean/godo v1.173.0
 	github.com/docker/cli v24.0.5+incompatible
 	github.com/docker/docker v25.0.6+incompatible
 	github.com/docker/docker-credential-helpers v0.7.0 // indirect

go.sum

@@ -91,8 +91,8 @@ github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSs
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/digitalocean/godo v1.172.0 h1:7AYPfmCUlScyoQJF+3rVw17HR3V1+ogf2qmf2SND/DI=
-github.com/digitalocean/godo v1.172.0/go.mod h1:xQsWpVCCbkDrWisHA72hPzPlnC+4W5w/McZY5ij9uvU=
+github.com/digitalocean/godo v1.173.0 h1:tgzevGhlz9VFjk2y3NmeItUT4vIVVCRFETlG/1GlEQI=
+github.com/digitalocean/godo v1.173.0/go.mod h1:xQsWpVCCbkDrWisHA72hPzPlnC+4W5w/McZY5ij9uvU=
 github.com/distribution/reference v0.6.0 h1:0IXCQ5g4/QMHHkarYzh5l+u8T3t73zM5QvfrDyIgxBk=
 github.com/distribution/reference v0.6.0/go.mod h1:BbU0aIcezP1/5jX/8MP0YiH4SdvB5Y4f/wlDRiLyi3E=
 github.com/docker/cli v24.0.5+incompatible h1:WeBimjvS0eKdH4Ygx+ihVq1Q++xg36M/rMi4aXAvodc=

vendor/github.com/digitalocean/godo/CHANGELOG.md

@@ -61,7 +61,7 @@ github.com/creack/pty
 # github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
 ## explicit
 github.com/davecgh/go-spew/spew
-# github.com/digitalocean/godo v1.172.0
+# github.com/digitalocean/godo v1.173.0
 ## explicit; go 1.23.0
 github.com/digitalocean/godo
 github.com/digitalocean/godo/metrics