Skip to content

Commit 846fdca

Browse files
authored
chore!: use @icp-sdk/core in imports (#4455)
* use @icp-sdk/core instead * fix vite dedupe * revert local candid * bump candid_parser * pin serde to avoid dependency mess * clippy * update a bunch of references * libobjc is ok because its part of macos by default * use new response-verification commit * ignore advisory * changelog * fmt * update frontend canister * warn is now warning * cleanup
1 parent 9ffbb0f commit 846fdca

File tree

48 files changed

+1234
-1230
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+1234
-1230
lines changed

.github/workflows/audit.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ jobs:
3535
- uses: actions/checkout@v4
3636
- uses: actions-rust-lang/audit@v1
3737
with:
38+
# RUSTSEC-2026-0001
3839
# TODO: remove this once the fix is backported to rkyv v0.7
3940
# https://github.com/rkyv/rkyv/issues/644
40-
ignore: RUSTSEC-2026-0001
41+
42+
# RUSTSEC-2024-0437
43+
# Ok to ignore because it is only used in the monorepo, which forbids using the affected type.
44+
45+
ignore: RUSTSEC-2026-0001,RUSTSEC-2024-0437

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
- name: Check dynamically-linked libraries (macos)
8787
run: |
8888
ACTUAL="$(otool -L ${{ matrix.binary_path }}/dfx | awk 'NR > 1{ print $1 }' | grep -v /System/Library/Frameworks | sort | awk -v d=" " '{s=(NR==1?s:s d)$0}END{printf "%s",s}')"
89-
EXPECTED="/usr/lib/libSystem.B.dylib /usr/lib/libc++.1.dylib /usr/lib/libiconv.2.dylib"
89+
EXPECTED="/usr/lib/libSystem.B.dylib /usr/lib/libc++.1.dylib /usr/lib/libiconv.2.dylib /usr/lib/libobjc.A.dylib"
9090
echo "Dynamically-linked libraries:"
9191
echo " Actual: $ACTUAL"
9292
echo " Expected: $EXPECTED"

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
# UNRELEASED
44

5+
### chore!: `dfx generate` now imports `@icp-sdk/core` instead of `@dfinity/` packages
6+
7+
It is possible to restore the previous behavior by replacing uses of `dfx generate` with e.g. `dfx generate && find src/declarations -type f -exec perl -i -pe 's|@dfinity/|@icp-sdk/core/|g' {} +`.
8+
Most projects will want to substitute this in the frontend's `package.json`, in the `"prebuild"` step.
9+
510
### feat: support for canister ID migration
611

712
Canister ID migration can be performed using `dfx canister migrate-id`
@@ -31,6 +36,11 @@ This incorporates the following executed proposals:
3136
- [139766](https://dashboard.internetcomputer.org/proposal/139766)
3237
- [139674](https://dashboard.internetcomputer.org/proposal/139674)
3338

39+
### Frontend canister
40+
41+
- Module hash: 2830d9934ea6ec87e35e3a8b56dda562a3b09c1f94cd1fa3c0db3c2e41a4340c
42+
- https://github.com/dfinity/sdk/pull/4455
43+
3444
# 0.30.2
3545

3646
### Frontend canister

0 commit comments

Comments
 (0)