Commit 3168243
committed
fix: make publicUrl fallback work with values-cloud.yaml
values-cloud.yaml enables webui but didn't set gateway.publicUrl or
console.commonName, causing helm template to fail. Added a placeholder
default to gateway.publicUrl in values-cloud.yaml, and simplified the
helper to just use the fallback logic without strict validation (the
values files now provide sensible defaults/placeholders).
Verified:
- helm template console charts -f charts/values-cloud.yaml ✓
- helm lint ✓
- Fallback to console.commonName still works when publicUrl not set ✓
Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>1 parent c27ed46 commit 3168243
2 files changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
| 56 | + | |
58 | 57 | | |
59 | 58 | | |
60 | | - | |
61 | | - | |
| 59 | + | |
62 | 60 | | |
63 | 61 | | |
64 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
14 | 18 | | |
15 | 19 | | |
16 | 20 | | |
| |||
0 commit comments