Skip to content

Commit cdf596e

Browse files
committed
feat: add more info to OnPlayerPause event
This is useful when the playback begins as paused.
1 parent 66dc16c commit cdf596e

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

cmd/daemon/controls.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,14 @@ func (p *AppPlayer) handlePlayerEvent(ctx context.Context, ev *player.Event) {
123123
p.state.player.IsBuffering = false
124124
p.updateState(ctx)
125125

126-
p.sess.Events().OnPlayerPause(p.primaryStream, p.state.trackPosition())
126+
p.sess.Events().OnPlayerPause(
127+
p.primaryStream,
128+
p.state.player.ContextUri,
129+
p.state.player.Options.ShufflingContext,
130+
p.state.player.PlayOrigin,
131+
p.state.tracks.CurrentTrack(),
132+
p.state.trackPosition(),
133+
)
127134

128135
p.app.server.Emit(&ApiEvent{
129136
Type: ApiEventTypePaused,

events/dummy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ func (d dummyEventManager) OnPlayerPlay(*player.Stream, string, bool, *connectpb
5252
func (d dummyEventManager) OnPlayerResume(*player.Stream, int64) {
5353
}
5454

55-
func (d dummyEventManager) OnPlayerPause(*player.Stream, int64) {
55+
func (d dummyEventManager) OnPlayerPause(*player.Stream, string, bool, *connectpb.PlayOrigin, *connectpb.ProvidedTrack, int64) {
5656
}
5757

5858
func (d dummyEventManager) OnPlayerSeek(*player.Stream, int64, int64) {

player/events.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ type EventManager interface {
3333

3434
OnPlayerPlay(stream *Stream, ctxUri string, shuffle bool, playOrigin *connectpb.PlayOrigin, track *connectpb.ProvidedTrack, pos int64)
3535
OnPlayerResume(stream *Stream, pos int64)
36-
OnPlayerPause(stream *Stream, pos int64)
36+
OnPlayerPause(stream *Stream, ctxUri string, shuffle bool, playOrigin *connectpb.PlayOrigin, track *connectpb.ProvidedTrack, pos int64)
3737
OnPlayerSeek(stream *Stream, oldPos, newPos int64)
3838
OnPlayerSkipForward(stream *Stream, pos int64, skipTo bool)
3939
OnPlayerSkipBackward(stream *Stream, pos int64)

0 commit comments

Comments
 (0)