Skip to content

Commit 571a69f

Browse files
committed
Cleanup after review
1 parent 7bc829d commit 571a69f

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

plugins/ui/docs/creating-layouts/creating-dashboards.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,4 @@ In this example, `connected_dashboards` holds the shared `filter_text` state. Bo
289289

290290
2. **State persistence**: Each nested dashboard maintains its own layout state. When the page is reloaded, the arrangement of panels within nested dashboards is preserved.
291291

292-
3. **Unlimited nesting**: Dashboards can be nested arbitrarily deep (dashboard in panel in dashboard in panel, etc.), though deeply nested layouts may become difficult for users to navigate.
293-
294-
4. **Performance**: Each nested dashboard creates its own layout instance. For most use cases this has negligible impact, but consider the complexity when creating many nested dashboards.
292+
3. **Performance**: Each nested dashboard creates its own layout instance. For most use cases this has negligible impact, but consider the complexity when creating many nested dashboards.

plugins/ui/src/js/src/layout/NestedDashboard.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react';
1+
import React, { useContext } from 'react';
22
import { render, screen } from '@testing-library/react';
33
import { LayoutManagerContext, useLayoutManager } from '@deephaven/dashboard';
44
import NestedDashboard from './NestedDashboard';
@@ -44,7 +44,7 @@ function PanelIdReader(): JSX.Element {
4444
* Helper component that reads from ReactPanelManagerContext
4545
*/
4646
function PanelManagerReader(): JSX.Element {
47-
const panelManager = React.useContext(ReactPanelManagerContext);
47+
const panelManager = useContext(ReactPanelManagerContext);
4848
return (
4949
<div data-testid="panel-manager">
5050
{panelManager != null ? 'has-manager' : 'no-manager'}

0 commit comments

Comments
 (0)