multi: Bridge UI (#3484)

* multi: Bridge UI

Adds a UI to the wallets page that allows users to bridge EVM assets
between chains.

Additionally:
- Communicates fees for bridge completion transactions to the initiator
- Adds an index to the eth transaction db to be able to query bridge
  initiations by asset ID.

* Fix simnet bridge and add fee balance check for bridge completion.

* Make bridge history pagination button style match tx history popup's buttons.

Author: martonp

client/asset/eth/eth.go

@@ -1014,11 +1014,11 @@ func (w *ETHWallet) Connect(ctx context.Context) (_ *sync.WaitGroup, err error)
 		w.bridges[acrossBridgeName] = acrossBridge
 	}
 
-	if usdcBridge, err := newUsdcBridge(w.assetID, w.net, w.node.contractBackend(), w.addr, w.node); err != nil {
+	/* if usdcBridge, err := newUsdcBridge(w.assetID, w.net, w.node.contractBackend(), w.addr, w.node); err != nil {
 		w.log.Errorf("Failed to initialize USDC bridge: %v", err)
 	} else {
 		w.bridges[usdcBridgeName] = usdcBridge
-	}
+	} */
 
 	if w.assetID == ethID {
 		if polygonBridge, err := newPolygonBridgeEth(ctx, w.node.contractBackend(), w.net, w.addr, w.node, w.log); err != nil {
@@ -1034,6 +1034,15 @@ func (w *ETHWallet) Connect(ctx context.Context) (_ *sync.WaitGroup, err error)
 		}
 	}
 
+	// Register simnet bridge for testing
+	if w.net == dex.Simnet {
+		if simnetBridge, err := newSimnetBridge(w.assetID, w.net, w.node.contractBackend(), w.addr, w.node.chainConfig().ChainID, w.log); err != nil {
+			w.log.Debugf("Simnet bridge not available: %v", err)
+		} else {
+			w.bridges[simnetBridgeName] = simnetBridge
+		}
+	}
+
 	w.bridgeManager, err = newBridgeManager(&bridgeManagerConfig{
 		ctx:             ctx,
 		baseChainID:     w.baseChainID,
@@ -1454,7 +1463,7 @@ func newBridgeManager(cfg *bridgeManagerConfig) (*bridgeManager, error) {
 		monitorInterval: cfg.monitorInterval,
 	}
 
-	pendingBridges, err := cfg.txDB.getPendingBridges()
+	pendingBridges, err := cfg.txDB.getPendingBridges(nil)
 	if err != nil {
 		return nil, fmt.Errorf("error getting pending bridges: %v", err)
 	}
@@ -1551,7 +1560,7 @@ func (bm *bridgeManager) checkPendingBridges(ctx context.Context) {
 // markBridgeComplete is called when the destination wallet has confirmed the
 // completion of a bridge. The pending bridge is removed from the manager and
 // the db is updated to reflect the completion.
-func (bm *bridgeManager) markBridgeComplete(initiationTxID string, completionTxIDs []string, amtReceived uint64, isComplete bool) {
+func (bm *bridgeManager) markBridgeComplete(initiationTxID string, completionTxIDs []string, amtReceived, fees uint64, isComplete bool) {
 	var deletePendingBridge bool
 	defer func() {
 		if !deletePendingBridge {
@@ -1582,6 +1591,7 @@ func (bm *bridgeManager) markBridgeComplete(initiationTxID string, completionTxI
 	bridgeTx.BridgeCounterpartTx.IDs = completionTxIDs
 	bridgeTx.BridgeCounterpartTx.Complete = isComplete
 	bridgeTx.BridgeCounterpartTx.AmountReceived = amtReceived
+	bridgeTx.BridgeCounterpartTx.Fees = fees
 	if err := bm.txDB.storeTx(bridgeTx); err != nil {
 		bm.log.Errorf("error storing completed bridge tx: %v", err)
 		return
@@ -3446,7 +3456,7 @@ func (w *assetWallet) BridgeContractApprovalStatus(ctx context.Context, bridgeNa
 	return w.bridgeContractApprovalStatus(ctx, bridge)
 }
 
-func (w *assetWallet) approveBridgeContract(ctx context.Context, bridge bridge) (string, error) {
+func (w *assetWallet) approveBridgeContract(ctx context.Context, bridge bridge, onConfirm func()) (string, error) {
 	approvalStatus, err := w.bridgeContractApprovalStatus(ctx, bridge)
 	if err != nil {
 		return "", fmt.Errorf("error checking approval status: %w", err)
@@ -3504,7 +3514,7 @@ func (w *assetWallet) approveBridgeContract(ctx context.Context, bridge bridge)
 		delete(w.approvalCache, bridgeAddr)
 		w.pendingApprovals[bridgeAddr] = &pendingApproval{
 			txHash:    tx.Hash(),
-			onConfirm: func() {},
+			onConfirm: onConfirm,
 		}
 		w.approvalsMtx.Unlock()
 
@@ -3518,15 +3528,15 @@ func (w *assetWallet) approveBridgeContract(ctx context.Context, bridge bridge)
 
 // ApproveBridgeContract approves the bridge contract to spend tokens on behalf
 // of the account handled by the wallet.
-func (w *assetWallet) ApproveBridgeContract(ctx context.Context, bridgeName string) (string, error) {
+func (w *assetWallet) ApproveBridgeContract(ctx context.Context, bridgeName string, onConfirm func()) (string, error) {
 	bridge, ok := w.bridges[bridgeName]
 	if !ok {
 		return "", fmt.Errorf("bridge %s not found", bridgeName)
 	}
-	return w.approveBridgeContract(ctx, bridge)
+	return w.approveBridgeContract(ctx, bridge, onConfirm)
 }
 
-func (w *assetWallet) unapproveBridgeContract(ctx context.Context, bridge bridge) (string, error) {
+func (w *assetWallet) unapproveBridgeContract(ctx context.Context, bridge bridge, onConfirm func()) (string, error) {
 	approvalStatus, err := w.bridgeContractApprovalStatus(ctx, bridge)
 	if err != nil {
 		return "", fmt.Errorf("error checking approval status: %w", err)
@@ -3581,7 +3591,7 @@ func (w *assetWallet) unapproveBridgeContract(ctx context.Context, bridge bridge
 		delete(w.approvalCache, bridgeAddr)
 		w.pendingApprovals[bridgeAddr] = &pendingApproval{
 			txHash:    tx.Hash(),
-			onConfirm: func() {},
+			onConfirm: onConfirm,
 		}
 		w.approvalsMtx.Unlock()
 
@@ -3594,12 +3604,12 @@ func (w *assetWallet) unapproveBridgeContract(ctx context.Context, bridge bridge
 }
 
 // UnapproveBridgeContract removes the approval for the bridge contract.
-func (w *assetWallet) UnapproveBridgeContract(ctx context.Context, bridgeName string) (string, error) {
+func (w *assetWallet) UnapproveBridgeContract(ctx context.Context, bridgeName string, onConfirm func()) (string, error) {
 	bridge, ok := w.bridges[bridgeName]
 	if !ok {
 		return "", fmt.Errorf("bridge %s not found", bridgeName)
 	}
-	return w.unapproveBridgeContract(ctx, bridge)
+	return w.unapproveBridgeContract(ctx, bridge, onConfirm)
 }
 
 func (w *assetWallet) initiateBridge(ctx context.Context, amt uint64, dest uint32, bridgeName string) (txID string, err error) {
@@ -3674,6 +3684,43 @@ func (w *assetWallet) InitiateBridge(ctx context.Context, amt uint64, dest uint3
 		return "", fmt.Errorf("insufficient balance: %d < %d", balance.Available, amt)
 	}
 
+	// Calculate the fee for the bridge initiation
+	bridge, ok := w.bridges[bridgeName]
+	if !ok {
+		return "", fmt.Errorf("bridge %s not found", bridgeName)
+	}
+	initiateGas := bridge.initiateBridgeGas(w.assetID)
+	maxFeeRateWei, _, err := w.recommendedMaxFeeRate(ctx)
+	if err != nil {
+		return "", fmt.Errorf("error calculating bridge fee rate: %w", err)
+	}
+	maxFeeRateGwei := dexeth.WeiToGweiCeil(maxFeeRateWei)
+	fee := initiateGas * maxFeeRateGwei
+
+	// Check fee balance
+	isToken := w.assetID != w.baseChainID
+	if isToken {
+		// For tokens, the fee is paid in the base asset
+		w.walletsMtx.RLock()
+		baseWallet := w.wallets[w.baseChainID]
+		w.walletsMtx.RUnlock()
+		if baseWallet == nil {
+			return "", fmt.Errorf("base wallet not found")
+		}
+		baseBal, err := baseWallet.balance()
+		if err != nil {
+			return "", fmt.Errorf("error getting base asset balance: %w", err)
+		}
+		if baseBal.Available < fee {
+			return "", fmt.Errorf("insufficient fee balance: required %d, available %d", fee, baseBal.Available)
+		}
+	} else {
+		// For base assets, the fee comes from the same balance as the amount
+		if balance.Available < amt+fee {
+			return "", fmt.Errorf("insufficient balance for amount + fee: required %d, available %d", amt+fee, balance.Available)
+		}
+	}
+
 	txID, err := w.initiateBridge(ctx, amt, dest, bridgeName)
 	if err != nil {
 		return "", err
@@ -3686,12 +3733,12 @@ func (w *assetWallet) InitiateBridge(ctx context.Context, amt uint64, dest uint3
 
 // MarkBridgeComplete is called when the bridge completion transaction has
 // been confirmed on the destination chain.
-func (w *assetWallet) MarkBridgeComplete(initiationTxID string, completionTxIDs []string, amtReceived uint64, complete bool) {
-	w.bridgeManager.markBridgeComplete(initiationTxID, completionTxIDs, amtReceived, complete)
+func (w *assetWallet) MarkBridgeComplete(initiationTxID string, completionTxIDs []string, amtReceived, fees uint64, complete bool) {
+	w.bridgeManager.markBridgeComplete(initiationTxID, completionTxIDs, amtReceived, fees, complete)
 }
 
 func (w *assetWallet) pendingBridges() ([]*asset.WalletTransaction, error) {
-	pendingBridges, err := w.txDB.getPendingBridges()
+	pendingBridges, err := w.txDB.getPendingBridges(&w.assetID)
 	if err != nil {
 		return nil, fmt.Errorf("error getting pending bridges: %w", err)
 	}
@@ -3715,7 +3762,7 @@ func (w *assetWallet) bridgeHistory(n int, refID *string, past bool) ([]*asset.W
 		rh := common.HexToHash(*refID)
 		refHash = &rh
 	}
-	return w.txDB.getBridges(n, refHash, past)
+	return w.txDB.getBridges(&w.assetID, n, refHash, past)
 }
 
 // BridgeHistory retrieves a record of bridge initiations on the blockchain.
@@ -3875,10 +3922,11 @@ func (w *assetWallet) completeBridgeIfNeeded(ctx context.Context, bridgeTx *asse
 	}
 
 	var completionTxIDs []string
+	var fees uint64
 	var sendNote, isComplete bool
 	defer func() {
 		if sendNote {
-			w.emit.BridgeCompleted(bridgeTx.AssetID, bridgeTx.IDs[0], completionTxIDs, amount, isComplete)
+			w.emit.BridgeCompleted(bridgeTx.AssetID, bridgeTx.IDs[0], completionTxIDs, amount, fees, isComplete)
 		}
 	}()
 
@@ -3913,6 +3961,7 @@ func (w *assetWallet) completeBridgeIfNeeded(ctx context.Context, bridgeTx *asse
 		if err != nil {
 			return fmt.Errorf("error completing bridge: %w", err)
 		}
+		// Send notification with isComplete=false. Fees are 0 since tx isn't confirmed.
 		completionTxIDs = []string{txID}
 		sendNote = true
 		return nil
@@ -3926,6 +3975,7 @@ func (w *assetWallet) completeBridgeIfNeeded(ctx context.Context, bridgeTx *asse
 	if !bridge.requiresFollowUpCompletion(w.assetID) {
 		isComplete = true
 		completionTxIDs = []string{wt.ID}
+		fees = wt.Fees
 		sendNote = true
 		return nil
 	}
@@ -3940,6 +3990,10 @@ func (w *assetWallet) completeBridgeIfNeeded(ctx context.Context, bridgeTx *asse
 		completionTxIDs = []string{wt.PreviousBridgeCompletionID, wt.ID}
 		isComplete = complete
 		if isComplete {
+			fees = wt.Fees
+			if prevTx, err := w.txDB.getTx(common.HexToHash(wt.PreviousBridgeCompletionID)); err == nil && prevTx != nil {
+				fees += prevTx.Fees
+			}
 			sendNote = true
 		}
 		return nil
@@ -3954,6 +4008,7 @@ func (w *assetWallet) completeBridgeIfNeeded(ctx context.Context, bridgeTx *asse
 	}
 	if !required {
 		completionTxIDs = []string{wt.ID}
+		fees = wt.Fees
 		isComplete = true
 		sendNote = true
 		return nil
@@ -3963,9 +4018,9 @@ func (w *assetWallet) completeBridgeIfNeeded(ctx context.Context, bridgeTx *asse
 	if err != nil {
 		return fmt.Errorf("error completing bridge: %w", err)
 	}
+	// Send notification with isComplete=false. Fees are 0 since follow-up tx isn't confirmed.
 	completionTxIDs = []string{wt.ID, txID}
 	sendNote = true
-
 	return nil
 }
 
@@ -3976,7 +4031,7 @@ func (w *assetWallet) CompleteBridge(ctx context.Context, bridgeTx *asset.Bridge
 }
 
 // SupportedDestinations returns the list of asset IDs that the wallet can bridge funds to.
-func (w *assetWallet) SupportedDestinations() (map[uint32][]string, error) {
+func (w *assetWallet) SupportedDestinations() map[uint32][]string {
 	allBridgeDestinations := map[uint32][]string{}
 
 	for bridgeName, bridge := range w.bridges {
@@ -3991,7 +4046,7 @@ func (w *assetWallet) SupportedDestinations() (map[uint32][]string, error) {
 			allBridgeDestinations[destination] = append(allBridgeDestinations[destination], bridgeName)
 		}
 	}
-	return allBridgeDestinations, nil
+	return allBridgeDestinations
 }
 
 // BridgeInitiationFeesAndLimits returns the estimated fees, limits, and whether the
@@ -4008,7 +4063,7 @@ func (w *assetWallet) BridgeInitiationFeesAndLimits(bridgeName string, destAsset
 	if err != nil {
 		return 0, [2]uint64{}, false, fmt.Errorf("error calculating bridge fee rate: %w", err)
 	}
-	maxFeeRateGwei := dexeth.WeiToGwei(maxFeeRateWei)
+	maxFeeRateGwei := dexeth.WeiToGweiCeil(maxFeeRateWei)
 
 	minBig, maxBig, hasLimits, err := bridge.bridgeLimits(w.assetID, destAssetID)
 	if err != nil {
@@ -4021,23 +4076,50 @@ func (w *assetWallet) BridgeInitiationFeesAndLimits(bridgeName string, destAsset
 	return initiateGas * maxFeeRateGwei, [2]uint64{min, max}, hasLimits, nil
 }
 
-// BridgeCompletionFees returns the estimated fees for completing a bridge.
-func (w *assetWallet) BridgeCompletionFees(bridgeName string) (uint64, error) {
+// BridgeCompletionFees returns the estimated fees for completing a bridge,
+// and whether the wallet has sufficient balance available to pay those fees.
+func (w *assetWallet) BridgeCompletionFees(bridgeName string) (uint64, bool, error) {
 	bridge, found := w.bridges[bridgeName]
 	if !found {
-		return 0, fmt.Errorf("bridge %s not found", bridgeName)
+		return 0, false, fmt.Errorf("bridge %s not found", bridgeName)
 	}
 
 	completeGas := bridge.completeBridgeGas(w.assetID)
 	followUpCompleteGas := bridge.followUpCompleteBridgeGas()
 
 	maxFeeRateWei, _, err := w.recommendedMaxFeeRate(w.ctx)
 	if err != nil {
-		return 0, fmt.Errorf("error calculating bridge fee rate: %w", err)
+		return 0, false, fmt.Errorf("error calculating bridge fee rate: %w", err)
+	}
+	maxFeeRateGwei := dexeth.WeiToGweiCeil(maxFeeRateWei)
+
+	fees := (completeGas + followUpCompleteGas) * maxFeeRateGwei
+
+	// Get available fee balance
+	var availableFeeBalance uint64
+	if w.assetID == w.baseChainID {
+		// Base asset - fees come from own balance
+		bal, err := w.balance()
+		if err != nil {
+			return fees, false, fmt.Errorf("error getting balance: %w", err)
+		}
+		availableFeeBalance = bal.Available
+	} else {
+		// Token - fees come from parent asset
+		w.walletsMtx.RLock()
+		baseWallet := w.wallets[w.baseChainID]
+		w.walletsMtx.RUnlock()
+		if baseWallet == nil {
+			return fees, false, fmt.Errorf("base wallet not found")
+		}
+		bal, err := baseWallet.balance()
+		if err != nil {
+			return fees, false, fmt.Errorf("error getting base asset balance: %w", err)
+		}
+		availableFeeBalance = bal.Available
 	}
-	maxFeeRateGwei := dexeth.WeiToGwei(maxFeeRateWei)
 
-	return (completeGas + followUpCompleteGas) * maxFeeRateGwei, nil
+	return fees, availableFeeBalance >= fees, nil
 }
 
 func (w *ETHWallet) canRedeemWithBundler(lotSize uint64, gases *dexeth.Gases, n uint64) (bool, error) {