fixing some warning messages

Author: ddovod

src/jet/live/DepfileDependenciesHandler.cpp

@@ -6,6 +6,17 @@
 #include <teenypath.h>
 #include "jet/live/LiveContext.hpp"
 
+namespace
+{
+    bool endsWith(const std::string& value, const std::string& ending)
+    {
+        if (ending.size() > value.size()) {
+            return false;
+        }
+        return std::equal(ending.rbegin(), ending.rend(), value.rbegin());
+    }
+}
+
 namespace jet
 {
     std::unordered_set<std::string> DepfileDependenciesHandler::getDependencies(const LiveContext* context,
@@ -31,7 +42,10 @@ namespace jet
         }
 
         if (cu.depFilePath.empty()) {
-            context->events->addLog(LogSeverity::kWarning, "Empty depfile path for cu: " + cu.sourceFilePath);
+            // asm files don't have deps and it's okay
+            if (!::endsWith(cu.sourceFilePath, ".asm")) {
+                context->events->addLog(LogSeverity::kWarning, "Empty depfile path for cu: " + cu.sourceFilePath);
+            }
             return deps;
         }
 

src/jet/live/_macos/MachoProgramInfoLoader.cpp

@@ -31,6 +31,12 @@
 namespace
 {
     uintptr_t thisExecutableLoadAddress = 0;
+
+    bool isSystemImage(const std::string& imagePathStr)
+    {
+        return imagePathStr.find("/usr/lib") != std::string::npos ||
+            imagePathStr.find("/System/Library") != std::string::npos;
+    }
 }
 
 namespace jet
@@ -41,6 +47,10 @@ namespace jet
 
         for (uint32_t i = 0; i < _dyld_image_count(); i++) {
             auto imagePath = TeenyPath::path{_dyld_get_image_name(i)};
+            // Skipping system images as they're not available anyway
+            if (::isSystemImage(imagePath.string())) {
+                continue;
+            }
             if (imagePath.exists()) {
                 imagePath = imagePath.resolve_absolute();
                 if (imagePath.string() == context->thisExecutablePath) {
@@ -66,6 +76,10 @@ namespace jet
         std::string realFilepath = filepath.empty() ? context->thisExecutablePath : filepath;
         for (uint32_t i = 0; i < _dyld_image_count(); i++) {
             auto imagePath = TeenyPath::path{_dyld_get_image_name(i)};
+            // Skipping system images as they're not available anyway
+            if (::isSystemImage(imagePath.string())) {
+                continue;
+            }
             if (imagePath.exists()) {
                 imagePath = imagePath.resolve_absolute();
                 if (imagePath.string() == realFilepath) {