Skip to content

Commit 3206c3c

Browse files
committed
Address PR 26 validation doc review
1 parent ded8749 commit 3206c3c

3 files changed

Lines changed: 12 additions & 9 deletions

File tree

docs/validation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ python3 evals/check_skill_package.py
2323
### Example Item
2424

2525
```md
26-
### WL-20260507-001 - Check error logs after deployment
26+
### WL-20260507-001 Check error logs after deployment
2727
- status: open
2828
- priority: P1
2929
- owner: assistant_on_review

evals/check_policy_markers.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
"Required values for open items",
5959
"`--strict-safety` is intentionally conservative",
6060
"The validator requires every field key",
61+
"### WL-20260507-001 — Check error logs after deployment",
6162
"python3 evals/check_semantic_cases.py",
6263
"Semantic case checker",
6364
"Example Item",

evals/test_check_watchlist.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -796,10 +796,14 @@ def test_validation_doc_owns_field_and_strict_safety_expectations(self):
796796
self.assertIn("Recommended when known", validation)
797797
self.assertIn("Normally blank until checked", validation)
798798
self.assertIn("`--strict-safety` is intentionally conservative", validation)
799+
self.assertIn("### WL-20260507-001 — Check error logs after deployment", validation)
800+
self.assertNotIn("### WL-20260507-001 - Check error logs after deployment", validation)
799801

800802
def test_readmes_are_short_landing_pages_with_deep_doc_links(self):
801803
english = (REPO_ROOT / "README.md").read_text(encoding="utf-8")
802804
korean = (REPO_ROOT / "README.ko.md").read_text(encoding="utf-8")
805+
normalized_english = " ".join(english.split())
806+
normalized_korean = " ".join(korean.split())
803807

804808
self.assertLessEqual(len(english.splitlines()), 120)
805809
self.assertLessEqual(len(korean.splitlines()), 120)
@@ -816,6 +820,9 @@ def test_readmes_are_short_landing_pages_with_deep_doc_links(self):
816820
self.assertIn("docs/storage-and-privacy.md", english)
817821
self.assertIn("docs/validation.md", english)
818822
self.assertIn("docs/maintainers/release.md", english)
823+
self.assertIn("until runtime-smoked", normalized_english)
824+
self.assertIn("docs/runtime-smoke.md", english)
825+
self.assertIn("not the repository root", normalized_english)
819826

820827
self.assertIn("AgentSkills 호환 Markdown workflow", korean)
821828
self.assertIn("Codex, Claude Code, OpenClaw, Gemini CLI, Kilo, Hermes", korean)
@@ -830,6 +837,9 @@ def test_readmes_are_short_landing_pages_with_deep_doc_links(self):
830837
self.assertIn("docs/storage-and-privacy.md", korean)
831838
self.assertIn("docs/validation.md", korean)
832839
self.assertIn("docs/maintainers/release.md", korean)
840+
self.assertIn("runtime smoke 전까지 AgentSkills 호환/manual 지원", normalized_korean)
841+
self.assertIn("docs/runtime-smoke.md", korean)
842+
self.assertIn("리포지토리 루트가 아니라 `SKILL.md`가 루트에 있는 스킬 디렉토리", normalized_korean)
833843

834844
moved_headings = [
835845
"## Generated WATCHLIST Files",
@@ -852,8 +862,6 @@ def test_storage_doc_owns_generated_file_policy(self):
852862
storage = (REPO_ROOT / "docs" / "storage-and-privacy.md").read_text(
853863
encoding="utf-8"
854864
)
855-
normalized_english = " ".join(english.split())
856-
normalized_korean = " ".join(korean.split())
857865

858866
self.assertIn("docs/storage-and-privacy.md", english)
859867
self.assertIn("docs/storage-and-privacy.md", korean)
@@ -865,12 +873,6 @@ def test_storage_doc_owns_generated_file_policy(self):
865873
self.assertIn("The installable skill bundle is intentionally Python-free", storage)
866874
self.assertIn("source-repository maintainers run `tools/validate_watchlist.py`", storage)
867875
self.assertIn("AgentSkills-compatible runtimes such as Gemini CLI, Kilo, OpenClaw, and Hermes", storage)
868-
self.assertIn("until runtime-smoked", normalized_english)
869-
self.assertIn("docs/runtime-smoke.md", english)
870-
self.assertIn("not the repository root", normalized_english)
871-
self.assertIn("runtime smoke 전까지 AgentSkills 호환/manual 지원", normalized_korean)
872-
self.assertIn("docs/runtime-smoke.md", korean)
873-
self.assertIn("리포지토리 루트가 아니라 `SKILL.md`가 루트에 있는 스킬 디렉토리", normalized_korean)
874876

875877
def test_install_and_release_docs_openai_zip_packaging_uses_one_top_level_skill_folder(self):
876878
install = (REPO_ROOT / "docs" / "install.md").read_text(encoding="utf-8")

0 commit comments

Comments
 (0)