Deduplicate TerraformResourceName (#2995)

## Changes

The `TerraformResourceName` field was added to the description struct in
#1928. This PR removes the duplication between that field and the
`TerraformResourceName` function on all resources. It also uses this
value when interpolating Terraform resource references instead of
keeping another hardcoded value around. The value for the model serving
endpoint is updated to reflect the right value (it wasn't used before).


## Tests

Existing tests pass.

Author: pietern

bundle/config/resources.go

@@ -35,10 +35,6 @@ type ConfigResource interface {
 	// ResourceDescription returns a struct containing strings describing a resource
 	ResourceDescription() resources.ResourceDescription
 
-	// TerraformResourceName returns an equivalent name of the resource. For example "databricks_job"
-	// for jobs and "databricks_pipeline" for pipelines.
-	TerraformResourceName() string
-
 	// GetName returns the in-product name of the resource.
 	GetName() string
 
@@ -172,7 +168,7 @@ func (r *Resources) FindResourceByConfigKey(key string) (ConfigResource, error)
 	if len(found) > 1 {
 		keys := make([]string, 0, len(found))
 		for _, r := range found {
-			keys = append(keys, fmt.Sprintf("%s:%s", r.TerraformResourceName(), key))
+			keys = append(keys, fmt.Sprintf("%s:%s", r.ResourceDescription().TerraformResourceName, key))
 		}
 		return nil, fmt.Errorf("ambiguous: %s (can resolve to all of %s)", key, keys)
 	}

bundle/config/resources/apps.go

@@ -67,10 +67,6 @@ func (*App) ResourceDescription() ResourceDescription {
 	}
 }
 
-func (a *App) TerraformResourceName() string {
-	return "databricks_app"
-}
-
 func (a *App) InitializeURL(baseURL url.URL) {
 	if a.ModifiedStatus == "" || a.ModifiedStatus == ModifiedStatusCreated {
 		return

bundle/config/resources/clusters.go

@@ -58,10 +58,6 @@ func (*Cluster) ResourceDescription() ResourceDescription {
 	}
 }
 
-func (s *Cluster) TerraformResourceName() string {
-	return "databricks_cluster"
-}
-
 func (s *Cluster) InitializeURL(baseURL url.URL) {
 	if s.ID == "" {
 		return

bundle/config/resources/dashboard.go

@@ -81,10 +81,6 @@ func (*Dashboard) ResourceDescription() ResourceDescription {
 	}
 }
 
-func (*Dashboard) TerraformResourceName() string {
-	return "databricks_dashboard"
-}
-
 func (r *Dashboard) InitializeURL(baseURL url.URL) {
 	if r.ID == "" {
 		return

bundle/config/resources/job.go

@@ -65,10 +65,6 @@ func (j *Job) ResourceDescription() ResourceDescription {
 	}
 }
 
-func (j *Job) TerraformResourceName() string {
-	return "databricks_job"
-}
-
 func (j *Job) InitializeURL(baseURL url.URL) {
 	if j.ID == "" {
 		return

bundle/config/resources/mlflow_experiment.go

@@ -60,10 +60,6 @@ func (j *MlflowExperiment) ResourceDescription() ResourceDescription {
 	}
 }
 
-func (s *MlflowExperiment) TerraformResourceName() string {
-	return "databricks_mlflow_experiment"
-}
-
 func (s *MlflowExperiment) InitializeURL(baseURL url.URL) {
 	if s.ID == "" {
 		return

bundle/config/resources/mlflow_model.go

@@ -60,10 +60,6 @@ func (j *MlflowModel) ResourceDescription() ResourceDescription {
 	}
 }
 
-func (s *MlflowModel) TerraformResourceName() string {
-	return "databricks_mlflow_model"
-}
-
 func (s *MlflowModel) InitializeURL(baseURL url.URL) {
 	if s.ID == "" {
 		return

bundle/config/resources/model_serving_endpoint.go

@@ -64,14 +64,10 @@ func (j *ModelServingEndpoint) ResourceDescription() ResourceDescription {
 		PluralName:            "model_serving_endpoints",
 		SingularTitle:         "Model Serving Endpoint",
 		PluralTitle:           "Model Serving Endpoints",
-		TerraformResourceName: "databricks_model_serving_endpoint",
+		TerraformResourceName: "databricks_model_serving",
 	}
 }
 
-func (s *ModelServingEndpoint) TerraformResourceName() string {
-	return "databricks_model_serving"
-}
-
 func (s *ModelServingEndpoint) InitializeURL(baseURL url.URL) {
 	if s.ID == "" {
 		return

bundle/config/resources/pipeline.go

@@ -60,10 +60,6 @@ func (j *Pipeline) ResourceDescription() ResourceDescription {
 	}
 }
 
-func (p *Pipeline) TerraformResourceName() string {
-	return "databricks_pipeline"
-}
-
 func (p *Pipeline) InitializeURL(baseURL url.URL) {
 	if p.ID == "" {
 		return

bundle/config/resources/quality_monitor.go

@@ -52,10 +52,6 @@ func (*QualityMonitor) ResourceDescription() ResourceDescription {
 	}
 }
 
-func (s *QualityMonitor) TerraformResourceName() string {
-	return "databricks_quality_monitor"
-}
-
 func (s *QualityMonitor) InitializeURL(baseURL url.URL) {
 	if s.TableName == "" {
 		return