removed last_chainlock_hash field, only updated and persisted

Author: ZocoLini

dash-spv-ffi/src/types.rs

@@ -182,17 +182,13 @@ impl From<DetailedSyncProgress> for FFIDetailedSyncProgress {
 #[repr(C)]
 pub struct FFIChainState {
     pub last_chainlock_height: u32,
-    pub last_chainlock_hash: FFIString,
     pub current_filter_tip: u32,
 }
 
 impl From<ChainState> for FFIChainState {
     fn from(state: ChainState) -> Self {
         FFIChainState {
             last_chainlock_height: state.last_chainlock_height.unwrap_or(0),
-            last_chainlock_hash: FFIString::new(
-                &state.last_chainlock_hash.map(|h| h.to_string()).unwrap_or_default(),
-            ),
             current_filter_tip: 0, // FilterHeader not directly convertible to u32
         }
     }

dash-spv-ffi/tests/unit/test_type_conversions.rs

@@ -164,20 +164,13 @@ mod tests {
     fn test_chain_state_none_values() {
         let state = dash_spv::ChainState {
             last_chainlock_height: None,
-            last_chainlock_hash: None,
             sync_base_height: 0,
         };
 
         let ffi_state = FFIChainState::from(state);
 
         assert_eq!(ffi_state.last_chainlock_height, 0);
         assert_eq!(ffi_state.current_filter_tip, 0);
-
-        unsafe {
-            let hash_str = FFIString::from_ptr(ffi_state.last_chainlock_hash.ptr).unwrap();
-            assert_eq!(hash_str, "");
-            dash_spv_ffi_string_destroy(ffi_state.last_chainlock_hash);
-        }
     }
 
     #[test]

dash-spv/src/client/chainlock.rs

@@ -65,7 +65,6 @@ impl<W: WalletInterface, N: NetworkManager, S: StorageManager> DashSpvClient<W,
 
         // Update our confirmed chain tip
         state.last_chainlock_height = Some(chainlock.block_height);
-        state.last_chainlock_hash = Some(chainlock.block_hash);
 
         tracing::info!(
             "🔒 Updated confirmed chain tip to ChainLock at height {} ({})",

dash-spv/src/storage/state.rs

@@ -19,7 +19,6 @@ impl DiskStorageManager {
         // Store other state as JSON
         let state_data = serde_json::json!({
             "last_chainlock_height": state.last_chainlock_height,
-            "last_chainlock_hash": state.last_chainlock_hash,
             "sync_base_height": state.sync_base_height,
         });
 
@@ -47,10 +46,6 @@ impl DiskStorageManager {
                 .get("last_chainlock_height")
                 .and_then(|v| v.as_u64())
                 .map(|h| h as u32),
-            last_chainlock_hash: value
-                .get("last_chainlock_hash")
-                .and_then(|v| v.as_str())
-                .and_then(|s| s.parse().ok()),
             sync_base_height: value
                 .get("sync_base_height")
                 .and_then(|v| v.as_u64())

dash-spv/src/types.rs

@@ -246,9 +246,6 @@ pub struct ChainState {
     /// Last ChainLock height.
     pub last_chainlock_height: Option<u32>,
 
-    /// Last ChainLock hash.
-    pub last_chainlock_hash: Option<BlockHash>,
-
     /// Base height when syncing from a checkpoint (0 if syncing from genesis).
     pub sync_base_height: u32,
 }
@@ -272,7 +269,6 @@ impl std::fmt::Debug for ChainState {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         f.debug_struct("ChainState")
             .field("last_chainlock_height", &self.last_chainlock_height)
-            .field("last_chainlock_hash", &self.last_chainlock_hash)
             .field("sync_base_height", &self.sync_base_height)
             .finish()
     }