-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
code qualityNonfunctional improvements to the codebaseNonfunctional improvements to the codebasehigh priorityWork on these firstWork on these first
Description
-
The following methods should be modified to return
DavResourceorDavResourceWithChildrenobjects, as appropriate:DandiClient::get_all_dandisets()DandisetEndpoint::get()DandisetEndpoint::get_all_versions()VersionEndpoint::get()VersionEndpoint::get_metadata()VersionEndpoint::get_resource()VersionEndpoint::get_resource_with_children()VersionEndpoint::get_root_children()ZarrManClient::get_top_level_dirs()ZarrManClient::get_resources()ZarrManClient::get_resources_with_children()
-
The types that the above methods currently return should all have their visibilities restricted to
crate::dandiorcrate::zarrman, as appropriate -
Various types in
src/zarrman/resources.rsshould then be renamed for greater accuracy (made easier by the fact that these types no longer have to coexist alongsidecrate::danditypes):Manifest→ZarrManifestFolder→ZarrFolderManifestEntry→ZarrEntry
and likewise for enum variants
Metadata
Metadata
Assignees
Labels
code qualityNonfunctional improvements to the codebaseNonfunctional improvements to the codebasehigh priorityWork on these firstWork on these first