CORE-2064: fixed a bug in the app job view endpoint

Author: slr71

src/apps/metadata/params.clj

@@ -2,6 +2,7 @@
   (:require [apps.metadata.reference-genomes :refer [get-reference-genomes-by-id]]
             [apps.persistence.app-metadata :as persistence]
             [apps.util.conversions :as conv]
+            [honey.sql.helpers :as h]
             [kameleon.uuids :refer [uuidify]]
             [korma.core :as sql]))
 
@@ -69,6 +70,25 @@
       (sql/order [:parent_id :display_order])
       (sql/select)))
 
+(defn hsql-params-base-query
+  []
+  (-> (h/select [:p.description    :description]
+                [:p.id             :id]
+                [:p.name           :name]
+                [:p.label          :label]
+                [:p.is_visible     :is_visible]
+                [:p.required       :required]
+                [:p.omit_if_blank  :omit_if_blank]
+                [:p.ordering       :order]
+                [:p.parameter_type :type]
+                :p.retain
+                :p.is_implicit
+                :p.repeat_option_flag
+                :p.info_type
+                :p.data_format
+                :p.data_source)
+      (h/from [:task_param_listing :p])))
+
 (defn params-base-query
   []
   (-> (sql/select* [:task_param_listing :p])

src/apps/service/apps/de/job_view.clj

@@ -11,9 +11,13 @@
    [apps.service.apps.util :refer [paths-accessible?]]
    [apps.util.service :as service]
    [apps.util.config :as config]
+   [apps.util.db :as db]
    [apps.util.conversions :refer [remove-nil-vals]]
+   [clojure.java.jdbc :as jdbc]
    [clojure-commons.exception-util :as cxu]
-   [korma.core :refer [fields join order select subselect where]]
+   [honey.sql :as sql]
+   [honey.sql.helpers :as h]
+   [korma.core :refer [fields join order select where]]
    [slingshot.slingshot :refer [try+ throw+]]))
 
 (defn- format-step-resource-requirements
@@ -33,28 +37,31 @@
 
 (defn- mapped-input-subselect
   [step-id]
-  (subselect [:workflow_io_maps :wm]
-             (join [:input_output_mapping :iom] {:wm.id :iom.mapping_id})
-             (where {:iom.input      :p.id
-                     :wm.target_step step-id})))
-
-(defn- add-hidden-parameters-clause
-  [query include-hidden-params?]
-  (if-not include-hidden-params?
-    (where query {:p.is_visible true})
-    query))
+  (-> (h/select :*)
+      (h/from [:workflow_io_maps :wm])
+      (h/join [:input_output_mapping :iom] [:= :wm.id :iom.mapping_id])
+      (h/where [:and
+                [:= :iom.input :p.id]
+                [:= :wm.target_step step-id]])))
+
+(defn- get-parameters-query
+  [step-id group-id include-hidden-params?]
+  (-> (mp/hsql-params-base-query)
+      (h/order-by :p.display-order)
+      (h/where [:and
+                [:= :p.parameter_group_id group-id]
+                (when include-hidden-params? :p.is_visible)
+                [:and
+                 [:not [:exists (mapped-input-subselect step-id)]]
+                 [:or
+                  [:= :p.value_type "Input"]
+                  [:not [:coalesce :is_implicit false]]]]])
+      (sql/format)))
 
 (defn- get-parameters
-  [step-id group-id include-hidden-params?]
-  (-> (mp/params-base-query)
-      (order :p.display_order)
-      (where {:p.parameter_group_id group-id})
-      (add-hidden-parameters-clause include-hidden-params?)
-      (where (and [:not [:exists (mapped-input-subselect step-id)]]
-                  (or {:value_type  "Input"}
-                      {:is_implicit nil}
-                      {:is_implicit false})))
-      select))
+  [step-id group-id include-hidden-parameters]
+  (db/with-transaction [tx]
+    (jdbc/query tx (get-parameters-query step-id group-id include-hidden-parameters))))
 
 (defn- get-default-value
   [user type values]