misc: rerun tests on unloadEvent instead of on beforeunload#33456
Open
misc: rerun tests on unloadEvent instead of on beforeunload#33456
Conversation
…nsaved-changes-on-refresh' into mabel/issue-12584-unsaved-changes-on-refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/cypress-io/cypress-services/issues/12584
Additional details
Note
Medium Risk
Changes core runner lifecycle behavior for when tests are restarted and cookies/state are cleared, which could alter navigation/teardown timing across browsers.
Overview
Rerun/reset is now tied to real unload events. The runner (
event-manager.ts) stops triggering test restarts/state cleanup onbeforeunloadand instead does so onpagehidefor Chromium andunloadfor other browsers, avoiding reruns when abeforeunloadconfirmation is cancelled.Updates the
15.12.0changelog to document this behavior change under Misc.Written by Cursor Bugbot for commit 14dd14d. This will update automatically on new commits. Configure here.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?