Skip to content

Unexpected KO countdown outside the ring #113

@AndrejOrsula

Description

@AndrejOrsula

Hello,

During one of the games earlier today, I noticed a "potential" issue with the knockout countdown algorithm when one of the players fell off the ring.
The game was evaluated during CI run #7245, and the full replay of the game is attached below (the important bit starts from 1:45).

wrestling_potential_issue_with_ko_countdown_algo.mp4

I was confused at first, but I believe the KO countdown for the player outside the ring was not continuously triggered because the position of their head was higher compared to the other player (Z coordinate). This change was introduced via #96 according to the following description in #95.

Improve the KO countdown algorithm: when a robot gets below the height threshold, start the countdown for this robot. However, if the other robot gets below the first one, then stop the countdown for the first robot and start it for the second one, etc.

It is probably too late to discuss/change the knockout counter algorithm for the current edition, but I just wanted to bring it to your attention for future reference. :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions