Invalid SQL syntax generated for clickhouse database on join keys

[BlueMagma2]

Describe the bug
Invalid SQL syntax generated for clickhouse database when grouping by joined cubes
Cubejs generate join key of the form: (table1.col1 = table2.col2 OR ((table1.col1 IS NULL) AND (table2.col2 IS NULL))), trying to match keys having null values

Clickhouse doesn't support using "is null" in join keys

To Reproduce
make a query involving a group by over a joined cube with clickhouse as the database backend

Expected behavior
Generate another equivalent syntax compatible with clickhouse, for exemple COALESCE(table1.col1, -1) = COALESCE(table2.col2, -1) works

Version:
cubejs:1.3

[igorlukanin]

make a query involving a group by over a joined cube with clickhouse as the database backend

Hey @BlueMagma2 👋

Could you please submit a minimal data model example + a query that produce incorrect SQL?

I've tried to reproduce this myself but wasn't lucky enough so far.

[magno32]

@igorlukanin

This is affecting us too.

Attaching a cube yaml that causes the issue (executed against ClickHouse).

test_table.yml

This query fails:

{
  "measures": [
    "test_sales.units_prior_year",
    "test_sales.units"
  ],
  "dimensions": [
    "test_stores.name"
  ],
  "timeDimensions": [
    {
      "dimension": "test_sales.ts",
      "dateRange": "last year"
    }
  ]
}

This query works, if we do not induce a join:

{
  "measures": [
    "test_sales.units_prior_year",
    "test_sales.units"
  ],
  "dimensions": [],
  "timeDimensions": [
    {
      "dimension": "test_sales.ts",
      "dateRange": "last year"
    }
  ]
}