chore: fix

Author: ovr

packages/cubejs-backend-shared/src/env.ts

@@ -33,7 +33,7 @@ export function convertTimeStrToSeconds(
   throw new InvalidConfiguration(envName, input, description);
 }
 
-export function convertByteSizeToNumber(
+export function convertSizeToBytes(
   input: string,
   envName: string,
   description: string = 'Must be a number in bytes or size string (1kb, 1mb, 1gb).',
@@ -175,7 +175,7 @@ const variables: Record<string, (...args: any) => any> = {
   serverKeepAliveTimeout: () => get('CUBEJS_SERVER_KEEP_ALIVE_TIMEOUT')
     .asInt(),
   maxRequestSize: () => {
-    const value = convertByteSizeToNumber(process.env.CUBEJS_MAX_REQUEST_SIZE || '50mb', 'CUBEJS_MAX_REQUEST_SIZE');
+    const value = convertSizeToBytes(process.env.CUBEJS_MAX_REQUEST_SIZE || '50mb', 'CUBEJS_MAX_REQUEST_SIZE');
 
     const minBytes = 100 * 1024; // 100kb
     const maxBytes = 64 * 1024 * 1024; // 64mb

packages/cubejs-backend-shared/src/index.ts

@@ -3,7 +3,7 @@ export {
   assertDataSource,
   keyByDataSource,
   isDockerImage,
-  convertByteSizeToNumber,
+  convertSizeToBytes,
 } from './env';
 export * from './enums';
 export * from './package';

packages/cubejs-backend-shared/test/env.test.ts

@@ -1,4 +1,4 @@
-import { getEnv, convertTimeStrToSeconds, convertByteSizeToNumber } from '../src/env';
+import { getEnv, convertTimeStrToSeconds, convertSizeToBytes } from '../src/env';
 
 test('convertTimeStrToMs', () => {
   expect(convertTimeStrToSeconds('1', 'VARIABLE_ENV')).toBe(1);
@@ -17,23 +17,23 @@ test('convertTimeStrToMs(exception)', () => {
 });
 
 test('convertByteSizeToNumber', () => {
-  expect(convertByteSizeToNumber('1024', 'VARIABLE_ENV')).toBe(1024);
-  expect(convertByteSizeToNumber('1kb', 'VARIABLE_ENV')).toBe(1024);
-  expect(convertByteSizeToNumber('10KB', 'VARIABLE_ENV')).toBe(10 * 1024);
-  expect(convertByteSizeToNumber('1mb', 'VARIABLE_ENV')).toBe(1024 * 1024);
-  expect(convertByteSizeToNumber('50MB', 'VARIABLE_ENV')).toBe(50 * 1024 * 1024);
-  expect(convertByteSizeToNumber('1gb', 'VARIABLE_ENV')).toBe(1024 * 1024 * 1024);
-  expect(convertByteSizeToNumber('2GB', 'VARIABLE_ENV')).toBe(2 * 1024 * 1024 * 1024);
+  expect(convertSizeToBytes('1024', 'VARIABLE_ENV')).toBe(1024);
+  expect(convertSizeToBytes('1kb', 'VARIABLE_ENV')).toBe(1024);
+  expect(convertSizeToBytes('10KB', 'VARIABLE_ENV')).toBe(10 * 1024);
+  expect(convertSizeToBytes('1mb', 'VARIABLE_ENV')).toBe(1024 * 1024);
+  expect(convertSizeToBytes('50MB', 'VARIABLE_ENV')).toBe(50 * 1024 * 1024);
+  expect(convertSizeToBytes('1gb', 'VARIABLE_ENV')).toBe(1024 * 1024 * 1024);
+  expect(convertSizeToBytes('2GB', 'VARIABLE_ENV')).toBe(2 * 1024 * 1024 * 1024);
 });
 
 test('convertByteSizeToNumber(exception)', () => {
-  expect(() => convertByteSizeToNumber('', 'VARIABLE_ENV')).toThrowError(
+  expect(() => convertSizeToBytes('', 'VARIABLE_ENV')).toThrowError(
     `Value "" is not valid for VARIABLE_ENV. Must be a number in bytes or size string (1kb, 1mb, 1gb).`
   );
-  expect(() => convertByteSizeToNumber('abc', 'VARIABLE_ENV')).toThrowError(
+  expect(() => convertSizeToBytes('abc', 'VARIABLE_ENV')).toThrowError(
     `Value "abc" is not valid for VARIABLE_ENV. Must be a number in bytes or size string (1kb, 1mb, 1gb).`
   );
-  expect(() => convertByteSizeToNumber('1tb', 'VARIABLE_ENV')).toThrowError(
+  expect(() => convertSizeToBytes('1tb', 'VARIABLE_ENV')).toThrowError(
     `Value "1tb" is not valid for VARIABLE_ENV. Must be a number in bytes or size string (1kb, 1mb, 1gb).`
   );
 });