[Bug]: Immense Lag when typing

[audenh]

Bug Description

Hiya! I love this plugin, and I can't wait to see it get more popular (got straight A's for finals!!!!)

I noticed some immense lag when I'm typing, specifically when there's a lot of text all at once. The culprit is LearnKit. Looking at the code in dev tools, it brought me to column 52118, which seems to correspond with

LearnKit/src/views/reading/reading-refresh-runtime.ts

Line 213 in e08eb8a

const scheduleModeScan = () => {

I have very little JavaScript knowledge, but this does seem to be the culprit as I have been able to reproduce this on completely clean vaults.

When you have other plugins that also use similar listeners, the lag becomes even worse, to the point where the editor is unresponsive for a few seconds.

Attached is the performance profiler.

Please let me know if I can do anything else! This plugin is awesome and I would love to help it grow :)

Steps to Reproduce

1. Install LearnKit (I think I'm on latest 1.5.3?)
2. Create a new note
3. Install other plugins like Notebook Navigator that also utilize listeners (THIS STEP IS OPTIONAL!)
4. Switch to live preview OR source
5. Spam a lot of text (probably dozens of characters per second)
6. Your editor will become unresponsive

Expected Behavior

No lag :(

LearnKit Version

1.5.3

Obsidian Version

1.12.7

Operating System

Windows

Additional Context

No response

[ctrlaltwill]

Hi, the 1.5.3 build is pre-release. I am still actively working on it.

I have uploaded new build files to dist. Can you download main.js and styles.css from dist and copy them into your Learnkit plugin folder and then run the same test? I think this may fix this but would love you to test it!

Thanks,
Will

[audenh]

Hmmm, doesn't seem to work. Did the same test, profiler ends up pointing towards line 229:50750. Same as before. The code at 229:50750:

        let c = () => {
            o(window.setTimeout( () => {
                o(null),
                l(),
                c()
            }
            , 180))
        }
        ;
        c(),
        n.readingModeWatcherInterval != null && i(n.readingModeWatcherInterval)

Also, to be clear, this issue has existed for as long as I have used learnkit, but now I finally have the time to figure out where it is :P

[audenh]

Interesting, after manually editing the 180ms to be 9999999, it is no longer the culprit of the lag, but has become something else:

The code it is pointing to deals with the tooltips, which is consistent with the getBoundingClientRect being everywhere in the profiler.

So sorry for the spam. Hope the information I'm providing can help :)

[ctrlaltwill]

Hey @audenh, I'm trying to incorporate fixes for this while also improving compliance for Obsidian community review. Can you test out release 1.5.6? You can do it via BRAT or from dist. Thanks for your help! The spam is appreciated, I want to fix this for you and other users.

Edit: I am manually removing and adding new releases as I test against the new plugin database from Obsidian. Download whatever the latest release is (after 1.5.1) that is active and test against that! I am at 1.5.9 now and that will keep growing.

[audenh]

Unfortunately, no improvement yet. Seems like something is constantly forcing style recalculations, and the thread keeps getting backed up with recalculation requests. Maybe something in the code is causing the recalculations? The culprit has consistently pointed around 950:16310, which I think is

LearnKit/src/platform/core/tooltip-positioner.ts

Line 204 in 72dc323

const onFocusOut = (ev: FocusEvent) => {

Thanks for the quick responses :)