Merge pull request #86 from steveluscher/prohibit-high-char-codes

Prohibit char codes that would overflow the `BASE_MAP`

Author: fanatid

src/cjs/index.cjs

@@ -82,8 +82,12 @@ function base (ALPHABET) {
     const b256 = new Uint8Array(size)
     // Process the characters.
     while (psz < source.length) {
+      // Find code of next character
+      const charCode = source.charCodeAt(psz)
+      // Base map can not be indexed using char code
+      if (charCode > 255) { return }
       // Decode character
-      let carry = BASE_MAP[source.charCodeAt(psz)]
+      let carry = BASE_MAP[charCode]
       // Invalid character
       if (carry === 255) { return }
       let i = 0

src/esm/index.js

@@ -80,8 +80,12 @@ function base (ALPHABET) {
     const b256 = new Uint8Array(size)
     // Process the characters.
     while (psz < source.length) {
+      // Find code of next character
+      const charCode = source.charCodeAt(psz)
+      // Base map can not be indexed using char code
+      if (charCode > 255) { return }
       // Decode character
-      let carry = BASE_MAP[source.charCodeAt(psz)]
+      let carry = BASE_MAP[charCode]
       // Invalid character
       if (carry === 255) { return }
       let i = 0

test/fixtures.json

@@ -660,6 +660,12 @@
       "alphabet": "0123456789fabcdef",
       "description": "poorly formed alphabet",
       "exception": "^TypeError: f is ambiguous$"
+    },
+    {
+      "alphabet": "base58",
+      "description": "character whose code exceeds the highest index of base map (>=256)",
+      "exception": "^Error: Non-base58 character$",
+      "string": "\u1000"
     }
   ]
 }

ts_src/index.ts

@@ -101,8 +101,14 @@ function base (ALPHABET: string): base.BaseConverter {
 
     // Process the characters.
     while (psz < source.length) {
+      // Find code of next character
+      const charCode = source.charCodeAt(psz)
+
+      // Base map can not be indexed using char code
+      if (charCode > 255) return
+
       // Decode character
-      let carry = BASE_MAP[source.charCodeAt(psz)]
+      let carry = BASE_MAP[charCode]
 
       // Invalid character
       if (carry === 255) return