feat(x/tieredrewards): ADR-006 implementation - tiered lock rewards#1249
Open
JayT106 wants to merge 120 commits intocrypto-org-chain:feat/tokenomicfrom
Open
feat(x/tieredrewards): ADR-006 implementation - tiered lock rewards#1249JayT106 wants to merge 120 commits intocrypto-org-chain:feat/tokenomicfrom
JayT106 wants to merge 120 commits intocrypto-org-chain:feat/tokenomicfrom
Conversation
…Tier, MsgDeleteTier and MsgUpdateTier to update tiers + add Tier and Position persistence and indexes
… and disallow transfer if delegator has an active incoming redelegation to the validator
…ockTier and MsgCommitDelegationToTier + some refactoring
…nds are transferred fresh from the tieredrewards module acc
… address only for IsDelegated as validation already accounts for correctness
JayT106
force-pushed
the
jt/pr1242-followup
branch
from
8cf1c9c to
13448cb
Compare
…g field assertions - Rename misleading TestPosition_IsActiveForGovernance to TestPosition_IsDelegated_WithExitState - Replace fragile Contains(err.Error(), "unauthorized") with ErrorIs(err, types.ErrNotPositionOwner) - Replace Contains(err.Error(), ...) with ErrorContains throughout test files - Add missing field assertions in TestSetAndGetPosition and genesis round-trip test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…cileAmountFromShares
…ngs to unbondingDelegtionMappings and redelegtionMappings + add AfterUnbondingCompleted and AfterRedelegtionCompleted hooks
…shed, AfterSlashUnbondingRedelegation to AfterUnbondingRedelegationSlashed and AfterSlashRedelegation to AfterRedelegationSlashed
Persist LastBonusAccrual when hook-driven bonus settlement hits an insufficient pool so unbonding and slashing do not lose or reprice the final accrued window. Document the lifecycle-hook semantics in ADR-006 and add regression coverage. Made-with: Cursor
Avoid rewriting unchanged secondary indexes on position updates and keep single-position reward refreshes in memory so tx flows persist once instead of write-read-write churn. Made-with: Cursor
Settle base and bonus rewards in a single position pass and reuse the same in-memory positions during slash handling to avoid extra validator position reloads and writes. Made-with: Cursor
Cover mixed insufficient bonus pool outcomes in the fused reward path and verify slash hooks preserve updated checkpoints without reloading validator positions. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the ADR-006 tiered lock rewards module.
current dependent PR crypto-org-chain/cosmos-sdk#1786