tests: remove temporary sqlite/plugin files from /tmp/ (#4332)

Author: mmetc

pkg/apiserver/apic_test.go

@@ -9,6 +9,7 @@ import (
 	"net/netip"
 	"net/url"
 	"os"
+	"path/filepath"
 	"reflect"
 	"sync"
 	"testing"
@@ -38,15 +39,21 @@ import (
 func getDBClient(t *testing.T, ctx context.Context) *database.Client {
 	t.Helper()
 
-	dbPath, err := os.CreateTemp("", "*sqlite")
-	require.NoError(t, err)
+	dbPath := filepath.Join(t.TempDir(), "test.sqlite")
+
 	dbClient, err := database.NewClient(ctx, &csconfig.DatabaseCfg{
 		Type:   "sqlite",
 		DbName: "crowdsec",
-		DbPath: dbPath.Name(),
+		DbPath: dbPath,
 	}, nil)
 	require.NoError(t, err)
 
+	t.Cleanup(func() {
+		if err := dbClient.Ent.Close(); err != nil {
+			t.Logf("cleanup: closing db: %v", err)
+		}
+	})
+
 	return dbClient
 }
 

pkg/apiserver/apiserver.go

@@ -470,7 +470,7 @@ func (s *APIServer) Close() {
 		s.papi.Shutdown() // papi also uses the dbClient
 	}
 
-	s.dbClient.Ent.Close()
+	s.dbClient.Close()
 
 	if s.flushScheduler != nil {
 		_ = s.flushScheduler.Shutdown()

pkg/csplugin/broker_suite_test.go

@@ -42,7 +42,7 @@ func (s *PluginSuite) SetupSuite() {
 
 	t := s.T()
 
-	s.buildDir, err = os.MkdirTemp("", "cs_plugin_test_build")
+	s.buildDir = t.TempDir()
 	require.NoError(t, err)
 
 	s.builtBinary = filepath.Join(s.buildDir, "notification-dummy")

pkg/database/database.go

@@ -108,3 +108,7 @@ func NewClient(ctx context.Context, config *csconfig.DatabaseCfg, logger *log.En
 		decisionBulkSize: config.DecisionBulkSize,
 	}, nil
 }
+
+func (c *Client) Close() error {
+	return c.Ent.Close()
+}