While adding this content to the tarball is correct and appropriate behavior, using data_files for the purpose means that these files are installed into the site-packages directory that autofaiss is installed into.
Among other things, this means that wrapping the autofaiss package with a different package manager that refuses to install packages with conflicting files makes it impossible to install both autofaiss and embedding-reader at the same time (at least until rom1504/embedding-reader#48 is merged).
While adding this content to the tarball is correct and appropriate behavior, using
data_filesfor the purpose means that these files are installed into thesite-packagesdirectory that autofaiss is installed into.Among other things, this means that wrapping the autofaiss package with a different package manager that refuses to install packages with conflicting files makes it impossible to install both autofaiss and embedding-reader at the same time (at least until rom1504/embedding-reader#48 is merged).